Skip to content

Commit 09c342e

Browse files
authored
Add enabled to metadata (#618)
1 parent e0158e5 commit 09c342e

File tree

5 files changed

+12
-1
lines changed

5 files changed

+12
-1
lines changed

packages/event-processor/__tests__/buildEventV1.spec.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ describe('buildEventV1', () => {
6262
ruleKey: 'expKey',
6363
flagKey: 'flagKey1',
6464
ruleType: 'experiment',
65+
enabled: true,
6566
}
6667

6768
const result = buildImpressionEventV1(impressionEvent)
@@ -88,6 +89,7 @@ describe('buildEventV1', () => {
8889
rule_key: 'expKey',
8990
rule_type: 'experiment',
9091
variation_key: 'varKey',
92+
enabled: true,
9193
},
9294
},
9395
],
@@ -159,6 +161,7 @@ describe('buildEventV1', () => {
159161
ruleKey: '',
160162
flagKey: 'flagKey1',
161163
ruleType: 'rollout',
164+
enabled: true,
162165
}
163166

164167
const result = buildImpressionEventV1(impressionEvent)
@@ -185,6 +188,7 @@ describe('buildEventV1', () => {
185188
rule_key: '',
186189
rule_type: 'rollout',
187190
variation_key: '',
191+
enabled: true,
188192
},
189193
},
190194
],
@@ -549,6 +553,7 @@ describe('buildEventV1', () => {
549553
ruleKey: 'expKey',
550554
flagKey: 'flagKey1',
551555
ruleType: 'experiment',
556+
enabled: true,
552557
}
553558

554559
const result = makeBatchedEventV1([impressionEvent, conversionEvent])
@@ -576,6 +581,7 @@ describe('buildEventV1', () => {
576581
rule_key: 'expKey',
577582
rule_type: 'experiment',
578583
variation_key: 'varKey',
584+
enabled: true,
579585
},
580586
},
581587
],

packages/event-processor/__tests__/v1EventProcessor.react_native.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ function createImpressionEvent() {
6666
ruleKey: 'expKey',
6767
flagKey: 'flagKey1',
6868
ruleType: 'experiment',
69+
enabled: false,
6970
}
7071
}
7172

packages/event-processor/__tests__/v1EventProcessor.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ function createImpressionEvent() {
6363
ruleKey: 'expKey',
6464
flagKey: 'flagKey1',
6565
ruleType: 'experiment',
66+
enabled: true,
6667
}
6768
}
6869

packages/event-processor/src/events.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export interface ImpressionEvent extends BaseEvent {
6161
ruleKey: string
6262
flagKey: string
6363
ruleType: string
64+
enabled: boolean
6465
}
6566

6667
export interface ConversionEvent extends BaseEvent {

packages/event-processor/src/v1/buildEventV1.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ namespace Visitor {
5252
rule_key: string;
5353
rule_type: string;
5454
variation_key: string;
55+
enabled: boolean;
5556
}
5657

5758
export type SnapshotEvent = {
@@ -143,7 +144,7 @@ function makeConversionSnapshot(conversion: ConversionEvent): Visitor.Snapshot {
143144
}
144145

145146
function makeDecisionSnapshot(event: ImpressionEvent): Visitor.Snapshot {
146-
const { layer, experiment, variation, ruleKey, flagKey, ruleType } = event
147+
const { layer, experiment, variation, ruleKey, flagKey, ruleType, enabled } = event
147148
let layerId = layer ? layer.id : null
148149
let experimentId = experiment ? experiment.id : null
149150
let variationId = variation ? variation.id : null
@@ -160,6 +161,7 @@ function makeDecisionSnapshot(event: ImpressionEvent): Visitor.Snapshot {
160161
rule_key: ruleKey,
161162
rule_type: ruleType,
162163
variation_key: variationKey,
164+
enabled: enabled,
163165
},
164166
},
165167
],

0 commit comments

Comments
 (0)