update

Author: raju-opti

lib/core/odp/odp_event_manager.ts

@@ -24,7 +24,7 @@ import { OdpConfig } from './odp_config';
 import { IOdpEventApiManager } from './odp_event_api_manager';
 import { invalidOdpDataFound } from './odp_utils';
 import { IUserAgentParser } from './user_agent_parser';
-import { scheduleMicrotaskOrTimeout } from '../../utils/microtask';
+import { scheduleMicrotask } from '../../utils/microtask';
 
 const MAX_RETRIES = 3;
 
@@ -394,7 +394,7 @@ export abstract class OdpEventManager implements IOdpEventManager {
 
     if (batch.length > 0) {
       // put sending the event on another event loop
-      scheduleMicrotaskOrTimeout(async () => {
+      scheduleMicrotask(async () => {
         let shouldRetry: boolean;
         let attemptNumber = 0;
         do {

lib/core/project_config/project_config_manager.ts

@@ -98,8 +98,12 @@ export class HttpPollingDatafileManager implements DatafileManager {
     if (updateInterval < MIN_UPDATE_INTERVAL) {
       logger.warn(UPDATE_INTERVAL_BELOW_MINIMUM_MESSAGE);
     }
+
+    // avoid unhandled promise rejection
+    this.startPromise.promise.catch(() => {});
+    this.startPromise.promise.catch(() => {});
   }
-  
+
   onUpdate(listener: Consumer<string>): Fn {
     return this.emitter.on('update', listener);
   }
@@ -154,7 +158,9 @@ export class HttpPollingDatafileManager implements DatafileManager {
   private async handleInitFailure(): Promise<void> {
     this.state = ServiceState.Failed;
     this.ticker.stop();
-    this.startPromise.reject(new Error('Failed to fetch datafile'));
+    const error = new Error('Failed to fetch datafile');
+    this.startPromise.reject(error);
+    this.stopPrommise.reject(error);
   }
 
   private async handleError(errorOrStatus: Error | number): Promise<void> {

lib/modules/datafile-manager/httpPollingDatafileManager.ts

@@ -42,7 +42,7 @@ import {
 import { newErrorDecision } from '../optimizely_decision';
 import OptimizelyUserContext from '../optimizely_user_context';
 // import { createProjectConfigManager, ProjectConfigManager } from '../core/project_config/project_config_manager';
-import { ProjectConfigManager } from '../project_config/project_config_manager';
+import { ProjectConfigManager } from '../project_config__/project_config_manager';
 import { createDecisionService, DecisionService, DecisionObj } from '../core/decision_service';
 import { getImpressionEvent, getConversionEvent } from '../core/event_builder';
 import { buildImpressionEvent, buildConversionEvent } from '../core/event_builder/event_helpers';

lib/optimizely/index.ts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+import { resolvablePromise, ResolvablePromise } from "./utils/promise/resolvablePromise";
+
 
 /**
  * The service interface represents an object with an operational state,
@@ -37,3 +39,46 @@ export interface Service {
   stop(): void;
   onTerminated(): Promise<void>;
 }
+
+export abstract class BaseService implements Service {
+  protected state: ServiceState;
+  protected startPromise: ResolvablePromise<void>;
+  protected stopPromise: ResolvablePromise<void>;
+
+  constructor() {
+    this.state = ServiceState.New;
+    this.startPromise = resolvablePromise();
+    this.stopPromise = resolvablePromise();
+    
+    // avoid unhandled promise rejection
+    this.startPromise.promise.catch(() => {});
+    this.stopPromise.promise.catch(() => {});
+  }
+
+  onRunning(): Promise<void> {
+    return this.startPromise.promise;
+  }
+
+  onTerminated(): Promise<void> {
+    return this.stopPromise.promise;
+  }
+
+  getState(): ServiceState {
+    return this.state;
+  }
+
+  protected isNew(): boolean {
+    return this.state === ServiceState.New;
+  }
+  
+  protected isDone(): boolean {
+    return [
+      ServiceState.Stopping,
+      ServiceState.Terminated,
+      ServiceState.Failed
+    ].includes(this.state);
+  }
+
+  abstract start(): void;
+  abstract stop(): void;
+}

lib/project_config/project_config_manager.ts renamed to lib/project_config__/project_config_manager.ts

@@ -38,7 +38,7 @@ import { IOdpManager } from './core/odp/odp_manager';
 import { IUserAgentParser } from './core/odp/user_agent_parser';
 import PersistentCache from './plugins/key_value_cache/persistentKeyValueCache';
 import { ProjectConfig } from './core/project_config';
-import { ProjectConfigManager } from './project_config/project_config_manager';
+import { ProjectConfigManager } from './project_config__/project_config_manager';
 
 export interface BucketerParams {
   experimentId: string;