Skip to content

Commit 247e91c

Browse files
fix(Event Processor): impression event attributes exp, var should be empty instead of null (#718)
## Summary - experimentId and variationId should be empty if no variation or experiment is found. ## Test plan - Manually tested - All tests pass
1 parent f2a711c commit 247e91c

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

packages/event-processor/CHANGELOG.MD

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
77
## [Unreleased]
88
Changes that have landed but are not yet released.
99

10+
## [0.9.2] - November 3, 2021
11+
12+
### Fixed
13+
- Impression event should send empty `experimentId` and `variationKey` instead of `null` when no `experiment` or `variation` is found.
14+
1015
## [0.9.1] - October 13, 2021
1116

1217
### Fixed

packages/event-processor/__tests__/buildEventV1.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@ describe('buildEventV1', () => {
181181
decisions: [
182182
{
183183
campaign_id: null,
184-
experiment_id: null,
185-
variation_id: null,
184+
experiment_id: "",
185+
variation_id: "",
186186
metadata: {
187187
flag_key: 'flagKey1',
188188
rule_key: '',

packages/event-processor/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/event-processor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@optimizely/js-sdk-event-processor",
3-
"version": "0.9.1",
3+
"version": "0.9.2",
44
"description": "Optimizely Full Stack Event Processor",
55
"author": "jordangarcia <[email protected]>",
66
"homepage": "https://github.com/optimizely/javascript-sdk/tree/master/packages/event-processor",

packages/event-processor/src/v1/buildEventV1.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ function makeConversionSnapshot(conversion: ConversionEvent): Visitor.Snapshot {
146146
function makeDecisionSnapshot(event: ImpressionEvent): Visitor.Snapshot {
147147
const { layer, experiment, variation, ruleKey, flagKey, ruleType, enabled } = event
148148
let layerId = layer ? layer.id : null
149-
let experimentId = experiment ? experiment.id : null
150-
let variationId = variation ? variation.id : null
149+
let experimentId = experiment?.id ?? ''
150+
let variationId = variation?.id ?? ''
151151
let variationKey = variation ? variation.key : ''
152152

153153
return {

0 commit comments

Comments
 (0)