[FSSDK-11101] cleanup OptiizelyOptions type (#997)

Author: raju-opti

lib/export_types.ts

@@ -33,7 +33,6 @@ export {
   Event,
   EventDispatcher,
   DatafileOptions,
-  OptimizelyOptions,
   UserProfileService,
   UserProfile,
   ListenerPayload,

lib/index.browser.ts

@@ -18,7 +18,7 @@ import configValidator from './utils/config_validator';
 import defaultEventDispatcher from './event_processor/event_dispatcher/default_dispatcher.browser';
 import sendBeaconEventDispatcher from './event_processor/event_dispatcher/send_beacon_dispatcher.browser';
 import * as enums from './utils/enums';
-import { OptimizelyDecideOption, Client, Config, OptimizelyOptions } from './shared_types';
+import { OptimizelyDecideOption, Client, Config } from './shared_types';
 import Optimizely from './optimizely';
 import { UserAgentParser } from './odp/ua_parser/user_agent_parser';
 import { getUserAgentParser } from './odp/ua_parser/ua_parser.browser';
@@ -57,7 +57,7 @@ const createInstance = function(config: Config): Client | null {
     logger = config.logger ? extractLogger(config.logger) : undefined;
     const errorNotifier = config.errorNotifier ? extractErrorNotifier(config.errorNotifier) : undefined;
 
-    const optimizelyOptions: OptimizelyOptions = {
+    const optimizelyOptions = {
       ...config,
       clientEngine: clientEngine || enums.JAVASCRIPT_CLIENT_ENGINE,
       clientVersion: clientVersion || enums.CLIENT_VERSION,

lib/optimizely/index.ts

@@ -31,7 +31,6 @@ import {
   Variation,
   FeatureFlag,
   FeatureVariable,
-  OptimizelyOptions,
   OptimizelyDecideOption,
   FeatureVariableValue,
   OptimizelyDecision,
@@ -111,6 +110,27 @@ type StringInputs = Partial<Record<InputKey, unknown>>;
 
 type DecisionReasons = (string | number)[];
 
+/**
+ * options required to create optimizely object
+ */
+export type OptimizelyOptions = {
+  projectConfigManager: ProjectConfigManager;
+  UNSTABLE_conditionEvaluators?: unknown;
+  clientEngine: string;
+  clientVersion?: string;
+  errorNotifier?: ErrorNotifier;
+  eventProcessor?: EventProcessor;
+  jsonSchemaValidator?: {
+    validate(jsonObject: unknown): boolean;
+  };
+  logger?: LoggerFacade;
+  userProfileService?: UserProfileService | null;
+  defaultDecideOptions?: OptimizelyDecideOption[];
+  odpManager?: OdpManager;
+  vuidManager?: VuidManager
+  disposable?: boolean;
+}
+
 export default class Optimizely implements Client {
   private disposeOnUpdate?: Fn;
   private readyPromise: Promise<unknown>;

lib/shared_types.ts

@@ -248,32 +248,6 @@ export enum OptimizelyDecideOption {
   EXCLUDE_VARIABLES = 'EXCLUDE_VARIABLES',
 }
 
-/**
- * options required to create optimizely object
- */
-export interface OptimizelyOptions {
-  projectConfigManager: ProjectConfigManager;
-  UNSTABLE_conditionEvaluators?: unknown;
-  clientEngine: string;
-  clientVersion?: string;
-  // TODO[OASIS-6649]: Don't use object type
-  // eslint-disable-next-line  @typescript-eslint/ban-types
-  datafile?: string | object;
-  datafileManager?: DatafileManager;
-  errorNotifier?: ErrorNotifier;
-  eventProcessor?: EventProcessor;
-  jsonSchemaValidator?: {
-    validate(jsonObject: unknown): boolean;
-  };
-  logger?: LoggerFacade;
-  sdkKey?: string;
-  userProfileService?: UserProfileService | null;
-  defaultDecideOptions?: OptimizelyDecideOption[];
-  odpManager?: OdpManager;
-  vuidManager?: VuidManager
-  disposable?: boolean;
-}
-
 /**
  * Optimizely Config Entities
  */