Skip to content

Commit 295394a

Browse files
revert: auto-formatting & doc additions for ref readability
1 parent 67267f6 commit 295394a

File tree

11 files changed

+167
-176
lines changed

11 files changed

+167
-176
lines changed

.devcontainer/devcontainer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
{
22
"name": "Javascript SDK",
33
"image": "mcr.microsoft.com/devcontainers/typescript-node:1-18-bookworm",
4-
54
"postCreateCommand": "cd /workspaces/javascript-sdk && npm install -g npm && npm install",
6-
75
"customizations": {
86
"vscode": {
97
"extensions": [
108
"dbaeumer.vscode-eslint",
119
"eamodio.gitlens",
1210
"esbenp.prettier-vscode",
11+
"Gruntfuggly.todo-tree",
1312
"github.vscode-github-actions",
1413
"Orta.vscode-jest",
1514
"ms-vscode.test-adapter-converter"

lib/core/notification_center/notification_registry.tests.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616

1717
import { expect } from 'chai';
18+
1819
import { NotificationRegistry } from './notification_registry';
1920

2021
describe('Notification Registry', () => {

lib/core/odp/odp_manager.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ export interface IOdpManager {
4949
registerVuid(vuid: string): void;
5050
}
5151

52-
/**
53-
* Possible statuses for the OdpManager
54-
*/
5552
export enum Status {
5653
Running,
5754
Stopped,
@@ -72,37 +69,28 @@ export abstract class OdpManager implements IOdpManager {
7269
*/
7370
private configPromise: ResolvablePromise<void>;
7471

75-
/**
76-
* The current status of the ODP Manager
77-
*/
7872
private status: Status = Status.Stopped;
7973

8074
/**
8175
* ODP Segment Manager which provides an interface to the remote ODP server (GraphQL API) for audience segments mapping.
8276
* It fetches all qualified segments for the given user context and manages the segments cache for all user contexts.
83-
* @private
84-
* @readonly
8577
*/
8678
private readonly segmentManager: IOdpSegmentManager;
8779

8880
/**
8981
* ODP Event Manager which provides an interface to the remote ODP server (REST API) for events.
9082
* It will queue all pending events (persistent) and send them (in batches of up to 10 events) to the ODP server when possible.
91-
* @protected
92-
* @readonly
9383
*/
9484
protected readonly eventManager: IOdpEventManager;
9585

9686
/**
9787
* Handler for recording execution logs
9888
* @protected
99-
* @readonly
10089
*/
10190
protected readonly logger: LogHandler;
10291

10392
/**
10493
* ODP configuration settings for identifying the target API and segments
105-
* @protected
10694
*/
10795
protected odpIntegrationConfig?: OdpIntegrationConfig;
10896

@@ -135,23 +123,12 @@ export abstract class OdpManager implements IOdpManager {
135123
}
136124
}
137125

138-
/**
139-
* Register a VUID with the ODP Manager in client side context
140-
* @param {string} vuid - Unique identifier of an anonymous vistor
141-
*/
142126
abstract registerVuid(vuid: string): void;
143127

144-
/**
145-
* @returns {Status} The current status of the ODP Manager
146-
*/
147128
getStatus(): Status {
148129
return this.status;
149130
}
150131

151-
/**
152-
* Starts the ODP Manager
153-
* @returns {Promise<void>} A promise that resolves when starting has completed
154-
*/
155132
async start(): Promise<void> {
156133
if (this.status === Status.Running) {
157134
return;
@@ -172,10 +149,6 @@ export abstract class OdpManager implements IOdpManager {
172149
return Promise.resolve();
173150
}
174151

175-
/**
176-
* Stops the ODP Manager
177-
* @returns A promise that resolves when stopping has completed
178-
*/
179152
async stop(): Promise<void> {
180153
if (this.status === Status.Stopped) {
181154
return;

0 commit comments

Comments
 (0)