Skip to content

Commit 2c23443

Browse files
[FSSDK-11197] condition improvement
1 parent a98552c commit 2c23443

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/utils/event_tag_utils/index.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ export function getRevenueValue(eventTags: EventTags, logger: LoggerFacade): num
4141
return null;
4242
}
4343

44-
const parsedRevenueValue =
45-
typeof rawValue === 'number' ? rawValue : typeof rawValue === 'string' ? parseInt(rawValue) : NaN;
44+
const parsedRevenueValue = typeof rawValue === 'string' ? parseInt(rawValue) : rawValue;
4645

4746
if (isFinite(parsedRevenueValue)) {
4847
logger.log(LOG_LEVEL.INFO, LOG_MESSAGES.PARSED_REVENUE_VALUE, MODULE_NAME, parsedRevenueValue);
@@ -66,8 +65,7 @@ export function getEventValue(eventTags: EventTags, logger: LoggerFacade): numbe
6665
return null;
6766
}
6867

69-
const parsedEventValue =
70-
typeof rawValue === 'number' ? rawValue : typeof rawValue === 'string' ? parseFloat(rawValue) : NaN;
68+
const parsedEventValue = typeof rawValue === 'string' ? parseFloat(rawValue): rawValue;
7169

7270
if (isFinite(parsedEventValue)) {
7371
logger.log(LOG_LEVEL.INFO, LOG_MESSAGES.PARSED_NUMERIC_VALUE, MODULE_NAME, parsedEventValue);

0 commit comments

Comments
 (0)