[FSSDK-10936] test adjustment

Author: junaed-optimizely

__mocks__/@react-native-async-storage/async-storage.ts

@@ -14,50 +14,62 @@
  * limitations under the License.
  */
 
- let items: {[key: string]: string} = {}
 export default class AsyncStorage {
-  static getItem(key: string, callback?: (error?: Error, result?: string) => void): Promise<string | null> {
-    return new Promise((resolve, reject) => {
-      switch (key) {
-        case 'keyThatExists':
-          resolve('{ "name": "Awesome Object" }')
-          break
-        case 'keyThatDoesNotExist':
-          resolve(null)
-          break
-        case 'keyWithInvalidJsonObject':
-          resolve('bad json }')
-          break
-        default:
-          setTimeout(() => resolve(items[key] || null), 1)
-      }
-    })
+  private static items: Record<string, string> = {};
+
+  static getItem(
+    key: string,
+    callback?: (error?: Error, result?: string | null) => void
+  ): Promise<string | null> {
+    return new Promise((resolve) => {
+      setTimeout(() => {
+        const value = AsyncStorage.items[key] || null;
+        callback?.(undefined, value);
+        resolve(value);
+      }, 1);
+    });
   }
 
-  static setItem(key: string, value: string, callback?: (error?: Error) => void): Promise<void> {
+  static setItem(
+    key: string,
+    value: string,
+    callback?: (error?: Error) => void
+  ): Promise<void> {
     return new Promise((resolve) => {
       setTimeout(() => {
-        items[key] = value
-        resolve()
-      }, 1)
-    })
+        AsyncStorage.items[key] = value;
+        callback?.(undefined);
+        resolve();
+      }, 1);
+    });
   }
 
-  static removeItem(key: string, callback?: (error?: Error, result?: string) => void): Promise<string | null> {
-    return new Promise(resolve => {
+  static removeItem(
+    key: string,
+    callback?: (error?: Error, result?: string | null) => void
+  ): Promise<string | null> {
+    return new Promise((resolve) => {
       setTimeout(() => {
-        items[key] && delete items[key]
-        // @ts-ignore
-        resolve()
-      }, 1)
-    })
+        const value = AsyncStorage.items[key] || null;
+        if (key in AsyncStorage.items) {
+          delete AsyncStorage.items[key];
+        }
+        callback?.(undefined, value);
+        resolve(value);
+      }, 1);
+    });
   }
 
-  static dumpItems(): {[key: string]: string} {
-    return items
+  static dumpItems(): Record<string, string> {
+    return { ...AsyncStorage.items }; // Return a copy for immutability
   }
-  
-  static clearStore(): void {
-    items = {}
+
+  static clearStore(): Promise<void> {
+    return new Promise((resolve) => {
+      setTimeout(() => {
+        AsyncStorage.items = {};
+        resolve();
+      }, 1);
+    });
   }
 }

tests/reactNativeAsyncStorageCache.spec.ts

@@ -14,25 +14,24 @@
  * limitations under the License.
  */
 
-import { describe, beforeEach, beforeAll, it, vi, expect } from 'vitest';
-
-vi.mock('@react-native-async-storage/async-storage');
-
+import { describe, beforeEach, it, vi, expect } from 'vitest';
 import ReactNativeAsyncStorageCache from '../lib/plugins/key_value_cache/reactNativeAsyncStorageCache';
-import AsyncStorage from '../__mocks__/@react-native-async-storage/async-storage';
+import  AsyncStorage from '../__mocks__/@react-native-async-storage/async-storage';
+
+vi.mock('../lib/utils/import.react_native/@react-native-async-storage/async-storage', () => {
+  return {
+    getDefaultAsyncStorage: () => AsyncStorage,
+  };
+});
 
 describe('ReactNativeAsyncStorageCache', () => {
   const TEST_OBJECT_KEY = 'testObject';
   const testObject = { name: 'An object', with: { some: 2, properties: ['one', 'two'] } };
   let cacheInstance: ReactNativeAsyncStorageCache;
 
-  beforeAll(() => {
-    cacheInstance = new ReactNativeAsyncStorageCache();
-  });
-
   beforeEach(() => {
-    AsyncStorage.clearStore();
-    AsyncStorage.setItem(TEST_OBJECT_KEY, JSON.stringify(testObject));
+    cacheInstance = new ReactNativeAsyncStorageCache();
+    cacheInstance.set(TEST_OBJECT_KEY, JSON.stringify(testObject));
   });
 
   describe('contains', () => {
@@ -77,16 +76,4 @@ describe('ReactNativeAsyncStorageCache', () => {
       expect(wasSuccessful).toBe(false);
     });
   });
-
-  describe('set', () => {
-    it('should resolve promise if item was successfully set in the cache', async () => {
-      const anotherTestStringValue = 'This should be found too.';
-
-      await cacheInstance.set('anotherTestStringValue', anotherTestStringValue);
-
-      const itemsInReactAsyncStorage = AsyncStorage.dumpItems();
-      expect(itemsInReactAsyncStorage['anotherTestStringValue']).toEqual(anotherTestStringValue);
-      expect(itemsInReactAsyncStorage[TEST_OBJECT_KEY]).toEqual(JSON.stringify(testObject));
-    });
-  });
 });