Skip to content

Commit 34dcc1f

Browse files
committed
fix
1 parent 0677663 commit 34dcc1f

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

lib/core/decision_service/index.tests.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1255,7 +1255,7 @@ describe('lib/core/decision_service', function() {
12551255
experiment = configObj.experimentIdMap['594098'];
12561256
getVariationStub = sandbox.stub(decisionServiceInstance, 'resolveVariation');
12571257
getVariationStub.returns(fakeDecisionResponse);
1258-
getVariationStub.withArgs(configObj, experiment, user).returns(fakeDecisionResponseWithArgs);
1258+
getVariationStub.withArgs('sync', configObj, experiment, user, sinon.match.any, sinon.match.any).returns(fakeDecisionResponseWithArgs);
12591259
});
12601260

12611261
it('returns a decision with a variation in the experiment the feature is attached to', function() {
@@ -1269,9 +1269,12 @@ describe('lib/core/decision_service', function() {
12691269
assert.deepEqual(decision, expectedDecision);
12701270
sinon.assert.calledWith(
12711271
getVariationStub,
1272+
'sync',
12721273
configObj,
12731274
experiment,
12741275
user,
1276+
sinon.match.any,
1277+
sinon.match.any
12751278
);
12761279
});
12771280
});

lib/core/decision_service/index.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1635,11 +1635,6 @@ export class DecisionService {
16351635
}
16361636
const decisionVariationValue = this.resolveVariation(op, configObj, rule, user, decideOptions, userProfileTracker);
16371637

1638-
// console.log('decisionVariationValue', decisionVariationValue, decisionVariationValue.then);
1639-
if (!decisionVariationValue.then) {
1640-
console.log('errorrrr >>>>> ', flagKey, rule.key, decisionVariationValue);
1641-
}
1642-
16431638
return decisionVariationValue.then((variationResult) => {
16441639
decideReasons.push(...variationResult.reasons);
16451640
return Value.of(op, {

0 commit comments

Comments
 (0)