fix: PR requested changes

Author: mikechu-optimizely

lib/core/odp/odp_manager.ts

@@ -46,7 +46,7 @@ export interface IOdpManager {
 
   sendEvent({ type, action, identifiers, data }: OdpEvent): void;
 
-  registerVuid(vuid: string | undefined): void;
+  registerVuid(vuid: string): void;
 }
 
 /**
@@ -139,7 +139,7 @@ export abstract class OdpManager implements IOdpManager {
    * Register a VUID with the ODP Manager in client side context
    * @param {string} vuid - Unique identifier of an anonymous vistor
    */
-  abstract registerVuid(vuid: string | undefined): void;
+  abstract registerVuid(vuid: string): void;
 
   /**
    * @returns {Status} The current status of the ODP Manager

lib/index.react_native.ts

@@ -28,8 +28,8 @@ import { OptimizelyDecideOption, Client, Config, VuidManagerOptions } from './sh
 import { createHttpPollingDatafileManager } from './plugins/datafile_manager/react_native_http_polling_datafile_manager';
 import { BrowserOdpManager } from './plugins/odp_manager/index.browser';
 import * as commonExports from './common_exports';
-import BrowserAsyncStorageCache from './plugins/key_value_cache/browserAsyncStorageCache';
 import { VuidManager } from './plugins/vuid_manager';
+import ReactNativeAsyncStorageCache from './plugins/key_value_cache/reactNativeAsyncStorageCache';
 import 'fast-text-encoding';
 import 'react-native-get-random-values';
 
@@ -109,7 +109,7 @@ const createInstance = function (config: Config): Client | null {
 
     const { clientEngine, clientVersion } = config;
 
-    const cache = new BrowserAsyncStorageCache();
+    const cache = new ReactNativeAsyncStorageCache();
     const vuidManagerOptions: VuidManagerOptions = {
       enableVuid: config.vuidManagerOptions?.enableVuid || false,
     }

lib/optimizely/index.ts

@@ -1424,7 +1424,10 @@ export default class Optimizely implements Client {
       resolveTimeoutPromise({
         success: true,
       });
-      this.odpManager?.registerVuid(this.vuidManager?.vuid)
+      const vuid = this.vuidManager?.vuid;
+      if (vuid) {
+        this.odpManager?.registerVuid(vuid);
+      }
     });
 
     return Promise.race([this.readyPromise, timeoutPromise]);

lib/plugins/odp_manager/index.browser.ts

@@ -150,7 +150,7 @@ export class BrowserOdpManager extends OdpManager {
     super.identifyUser(fsUserId, vuid);
   }
 
-  registerVuid(vuid: string | undefined): void {
+  registerVuid(vuid: string): void {
     if (!this.odpIntegrationConfig) {
       this.logger.log(LogLevel.ERROR, ERROR_MESSAGES.ODP_CONFIG_NOT_AVAILABLE);
       return;
@@ -161,11 +161,6 @@ export class BrowserOdpManager extends OdpManager {
       return;
     }
 
-    if (!vuid || !VuidManager.isVuid(vuid)) {
-      this.logger.log(LogLevel.ERROR, `The provided VUID ${vuid} is invalid.`);
-      return;
-    }
-
     try {
       this.eventManager.registerVuid(vuid);
     } catch (e) {

lib/plugins/odp_manager/index.node.ts

@@ -134,7 +134,7 @@ export class NodeOdpManager extends OdpManager {
     });
   }
 
-  registerVuid(vuid: string | undefined): void {
-    this.logger.log(LogLevel.ERROR, `Unable to registerVuid ${vuid || ''} in a node server context`);
+  registerVuid(vuid: string): void {
+    this.logger.log(LogLevel.ERROR, `Unable to registerVuid ${vuid} in a node server context`);
   }
 }