fix user context

Author: raju-opti

lib/notification_center/index.ts

@@ -73,10 +73,7 @@ export class DefaultNotificationCenter implements NotificationCenter, Notificati
    * @param   {ErrorHandler}               options.errorHandler An instance of errorHandler to handle any unexpected error
    */
   constructor(options: NotificationCenterOptions) {
-    const logger = options.logger?.child(MODULE_NAME);
-    const errorNotifier = options.errorNotifier?.child(MODULE_NAME);
-
-    this.errorReporter = new ErrorReporter(logger, errorNotifier);
+    this.errorReporter = new ErrorReporter(options.logger, options.errorNotifier);
   }
 
   /**

lib/optimizely_user_context/index.tests.js

@@ -51,15 +51,13 @@ var createLogger = () => ({
 });
 
 const getOptlyInstance = ({ datafileObj, defaultDecideOptions }) => {
-  const createdLogger = logger.createLogger({ logLevel: LOG_LEVEL.INFO });
+  const createdLogger = createLogger({ logLevel: LOG_LEVEL.INFO });
   const mockConfigManager = getMockProjectConfigManager({
     initConfig: createProjectConfig(datafileObj),
   });
   const eventDispatcher = getMockEventDispatcher();
   const eventProcessor = getForwardingEventProcessor(eventDispatcher);
 
-  const notificationCenter = createNotificationCenter({ logger: createdLogger, errorHandler: errorHandler });
-
   const optlyInstance = new Optimizely({
     clientEngine: 'node-sdk',
     projectConfigManager: mockConfigManager,
@@ -69,12 +67,10 @@ const getOptlyInstance = ({ datafileObj, defaultDecideOptions }) => {
     isValidInstance: true,
     eventBatchSize: 1,
     defaultDecideOptions: defaultDecideOptions || [],
-    notificationCenter,
   });
 
-  sinon.stub(notificationCenter, 'sendNotifications');
 
-  return { optlyInstance, eventProcessor, eventDispatcher, notificationCenter, createdLogger }
+  return { optlyInstance, eventProcessor, eventDispatcher, createdLogger }
 }
 
 describe('lib/optimizely_user_context', function() {
@@ -341,25 +337,17 @@ describe('lib/optimizely_user_context', function() {
         logLevel: LOG_LEVEL.DEBUG,
         logToConsole: false,
       });
-      var stubLogHandler;
-      let optlyInstance, notificationCenter, eventDispatcher;
 
-      beforeEach(function() {
-        stubLogHandler = {
-          log: sinon.stub(),
-        };
-        logging.setLogLevel('notset');
-        logging.setLogHandler(stubLogHandler);
+      let optlyInstance, eventDispatcher;
 
-        ({ optlyInstance, notificationCenter, createdLogger, eventDispatcher} = getOptlyInstance({
+      beforeEach(function() {
+        ({ optlyInstance, createdLogger, eventDispatcher} = getOptlyInstance({
           datafileObj: testData.getTestDecideProjectConfig(),
         }));
       });
 
       afterEach(function() {
-        logging.resetLogger();
         eventDispatcher.dispatchEvent.reset();
-        notificationCenter.sendNotifications.restore();
       });
 
       it('should return true when client is not ready', function() {
@@ -426,7 +414,7 @@ describe('lib/optimizely_user_context', function() {
         });
 
         afterEach(function() {
-          optlyInstance.decisionService.logger.log.restore();
+          // optlyInstance.decisionService.logger.log.restore();
           eventDispatcher.dispatchEvent.reset();
           optlyInstance.notificationCenter.sendNotifications.restore();
         });
@@ -504,10 +492,13 @@ describe('lib/optimizely_user_context', function() {
         });
 
         it('should return forced decision object when forced decision is set for a flag and dispatch an event', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance({
+          const { optlyInstance, eventDispatcher } = getOptlyInstance({
             datafileObj: testData.getTestDecideProjectConfig(),
           });
 
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var user = optlyInstance.createUserContext(userId);
           var featureKey = 'feature_1';
           var variationKey = '3324490562';
@@ -583,9 +574,13 @@ describe('lib/optimizely_user_context', function() {
         });
 
         it('should return forced decision object when forced decision is set for an experiment rule and dispatch an event', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance({
+          const { optlyInstance, eventDispatcher } = getOptlyInstance({
             datafileObj: testData.getTestDecideProjectConfig(),
           });
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var attributes = { country: 'US' };
           var user = optlyInstance.createUserContext(userId, attributes);
           var featureKey = 'feature_1';
@@ -668,9 +663,13 @@ describe('lib/optimizely_user_context', function() {
         });
 
         it('should return forced decision object when forced decision is set for a delivery rule and dispatch an event', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance({
+          const { optlyInstance, eventDispatcher } = getOptlyInstance({
             datafileObj: testData.getTestDecideProjectConfig(),
           });
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var user = optlyInstance.createUserContext(userId);
           var featureKey = 'feature_1';
           var variationKey = '3324490633';
@@ -939,18 +938,6 @@ describe('lib/optimizely_user_context', function() {
     });
 
     describe('#removeForcedDecision', function() {
-      var stubLogHandler;
-      beforeEach(function() {
-        stubLogHandler = {
-          log: sinon.stub(),
-        };
-        logging.setLogLevel('notset');
-        logging.setLogHandler(stubLogHandler);
-      });
-      afterEach(function() {
-        logging.resetLogger();
-      });
-
       it('should return true when client is not ready and the forced decision has been removed successfully', function() {
         fakeOptimizely = {
           isValidInstance: sinon.stub().returns(false),
@@ -1014,18 +1001,6 @@ describe('lib/optimizely_user_context', function() {
     });
 
     describe('#removeAllForcedDecisions', function() {
-      var stubLogHandler;
-      beforeEach(function() {
-        stubLogHandler = {
-          log: sinon.stub(),
-        };
-        logging.setLogLevel('notset');
-        logging.setLogHandler(stubLogHandler);
-      });
-      afterEach(function() {
-        logging.resetLogger();
-      });
-
       it('should return true when client is not ready', function() {
         fakeOptimizely = {
           isValidInstance: sinon.stub().returns(false),

package.json

@@ -74,7 +74,7 @@
     "clean:win": "(if exist dist rd /s/q dist)",
     "lint": "tsc --noEmit && eslint 'lib/**/*.js' 'lib/**/*.ts'",
     "test-vitest": "tsc --noEmit --p tsconfig.spec.json && vitest run",
-    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/**/*.tests.js'",
+    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/optimizely_user_context/*.tests.js'",
     "test": "npm run test-mocha && npm run test-vitest",
     "posttest": "npm run lint",
     "test-ci": "npm run test-xbrowser && npm run test-umdbrowser",