Skip to content

Commit 64d77e5

Browse files
feat: Upgrade TS to 4.0.3 in datafile-manager (#669)
* Upgrade TS * attempting to fix test failure * another attempt to fix tests * fixed package lock Co-authored-by: Zeeshan Ashraf <[email protected]>
1 parent 1b8557a commit 64d77e5

File tree

4 files changed

+3262
-3864
lines changed

4 files changed

+3262
-3864
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ jobs:
8282
- <<: *packagetest
8383
before_install: cd packages/logging
8484
- <<: *packagetest
85-
before_script: npm install "@react-native-async-storage/async-storage"
8685
before_install: cd packages/datafile-manager
8786

8887
- stage: 'Source Clear'

packages/datafile-manager/__test__/httpPollingDatafileManager.spec.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,7 @@ describe('httpPollingDatafileManager', () => {
297297
headers: {},
298298
});
299299
await responsePromise;
300+
await advanceTimersByTime(0);
300301
expect(makeGetRequestSpy).toBeCalledTimes(2);
301302
});
302303
});
@@ -334,7 +335,7 @@ describe('httpPollingDatafileManager', () => {
334335
await manager.onReady();
335336
expect(JSON.parse(manager.get())).toEqual({ foo: 'bar' });
336337

337-
advanceTimersByTime(1000);
338+
await advanceTimersByTime(1000);
338339

339340
expect(manager.responsePromises.length).toBe(2);
340341
manager.stop();
@@ -409,7 +410,7 @@ describe('httpPollingDatafileManager', () => {
409410
// First response promise was for the initial 200 response
410411
expect(manager.responsePromises.length).toBe(1);
411412
// Trigger the queued update
412-
advanceTimersByTime(1000);
413+
await advanceTimersByTime(1000);
413414
// Second response promise is for the 304 response
414415
expect(manager.responsePromises.length).toBe(2);
415416
await manager.responsePromises[1];
@@ -436,7 +437,7 @@ describe('httpPollingDatafileManager', () => {
436437
manager.start();
437438
await manager.onReady();
438439
const makeGetRequestSpy = jest.spyOn(manager, 'makeGetRequest');
439-
advanceTimersByTime(1000);
440+
await advanceTimersByTime(1000);
440441
expect(makeGetRequestSpy).toBeCalledTimes(1);
441442
const firstCall = makeGetRequestSpy.mock.calls[0];
442443
const headers = firstCall[1];
@@ -468,7 +469,7 @@ describe('httpPollingDatafileManager', () => {
468469
expect(makeGetRequestSpy).toBeCalledTimes(1);
469470

470471
// But after another 5 seconds, another request should be made
471-
advanceTimersByTime(5000);
472+
await advanceTimersByTime(5000);
472473
expect(makeGetRequestSpy).toBeCalledTimes(2);
473474
});
474475

0 commit comments

Comments
 (0)