opti fix

Author: raju-opti

lib/optimizely/index.tests.js

@@ -4505,6 +4505,15 @@ describe('lib/optimizely', function() {
         });
 
         it('should make a decision for feature_test and dispatch an event', function() {
+          const { optlyInstance, eventDispatcher } = getOptlyInstance(
+            {
+              datafileObj: testData.getTestDecideProjectConfig(),
+            }
+          );
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+          
           var flagKey = 'feature_2';
           var expectedVariables = optlyInstance.getAllFeatureVariables(flagKey, userId);
           var user = new OptimizelyUserContext({
@@ -4600,6 +4609,15 @@ describe('lib/optimizely', function() {
         });
 
         it('should make a decision and do not dispatch an event with DISABLE_DECISION_EVENT passed in decide options', function() {
+          const { optlyInstance, eventDispatcher } = getOptlyInstance(
+            {
+              datafileObj: testData.getTestDecideProjectConfig(),
+            }
+          );
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var flagKey = 'feature_2';
           var expectedVariables = optlyInstance.getAllFeatureVariables(flagKey, userId);
           var user = new OptimizelyUserContext({
@@ -4641,6 +4659,15 @@ describe('lib/optimizely', function() {
         });
 
         it('should make a decision with excluded variables and do not dispatch an event with DISABLE_DECISION_EVENT and EXCLUDE_VARIABLES passed in decide options', function() {
+          const { optlyInstance, eventDispatcher } = getOptlyInstance(
+            {
+              datafileObj: testData.getTestDecideProjectConfig(),
+            }
+          );
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var flagKey = 'feature_2';
           var user = new OptimizelyUserContext({
             optimizely: optlyInstance,
@@ -4684,11 +4711,15 @@ describe('lib/optimizely', function() {
         });
 
         it('should make a decision for rollout and dispatch an event when sendFlagDecisions is set to true', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance(
+          const { optlyInstance, eventDispatcher } = getOptlyInstance(
             {
               datafileObj: testData.getTestDecideProjectConfig(),
             }
-          )
+          );
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var flagKey = 'feature_1';
           var expectedVariables = optlyInstance.getAllFeatureVariables(flagKey, userId);
           var user = new OptimizelyUserContext({
@@ -4730,11 +4761,14 @@ describe('lib/optimizely', function() {
         });
 
         it('should make a decision for rollout and do not dispatch an event when sendFlagDecisions is set to false', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance(
+          const { optlyInstance, eventDispatcher } = getOptlyInstance(
             {
               datafileObj: testData.getTestDecideProjectConfig(),
             }
-          )
+          );
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
 
           var newConfig = optlyInstance.projectConfigManager.getConfig();
           newConfig.sendFlagDecisions = false;
@@ -4780,11 +4814,15 @@ describe('lib/optimizely', function() {
         });
 
         it('should make a decision when variation is null and dispatch an event', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance(
+          const { optlyInstance, eventDispatcher } = getOptlyInstance(
             {
               datafileObj: testData.getTestDecideProjectConfig(),
             }
-          )
+          );
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var flagKey = 'feature_3';
           var expectedVariables = optlyInstance.getAllFeatureVariables(flagKey, userId);
           var user = new OptimizelyUserContext({
@@ -4828,10 +4866,14 @@ describe('lib/optimizely', function() {
 
       describe('with EXCLUDE_VARIABLES flag in default decide options', function() {
         it('should exclude variables in decision object and dispatch an event', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance({
+          const { optlyInstance, eventDispatcher } = getOptlyInstance({
             datafileObj: testData.getTestDecideProjectConfig(),
             defaultDecideOptions: [OptimizelyDecideOption.EXCLUDE_VARIABLES],
-          })
+          });
+
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var flagKey = 'feature_2';
           var user = new OptimizelyUserContext({
             optimizely: optlyInstance,
@@ -4871,12 +4913,15 @@ describe('lib/optimizely', function() {
           assert.deepEqual(notificationCallArgs, expectedNotificationCallArgs);
         });
 
-        it.skip('should exclude variables in decision object and do not dispatch an event when DISABLE_DECISION_EVENT is passed in decide options', function() {
-          const { optlyInstance, notificationCenter, eventDispatcher } = getOptlyInstance({
+        it('should exclude variables in decision object and do not dispatch an event when DISABLE_DECISION_EVENT is passed in decide options', function() {
+          const { optlyInstance, eventDispatcher } = getOptlyInstance({
             datafileObj: testData.getTestDecideProjectConfig(),
             defaultDecideOptions: [OptimizelyDecideOption.EXCLUDE_VARIABLES],
           })
 
+          const notificationCenter = optlyInstance.notificationCenter;
+          sinon.stub(notificationCenter, 'sendNotifications');
+
           var flagKey = 'feature_2';
           var user = new OptimizelyUserContext({
             optimizely: optlyInstance,