test: fixed + associated code corrections

Author: mikechu-optimizely

lib/core/odp/odp_manager.ts

@@ -103,9 +103,8 @@ export abstract class OdpManager implements IOdpManager {
   /**
    * ODP configuration settings for identifying the target API and segments
    * @protected
-   * @readonly
    */
-  protected readonly odpIntegrationConfig?: OdpIntegrationConfig;
+  protected odpIntegrationConfig?: OdpIntegrationConfig;
 
   constructor({
     odpIntegrationConfig,

lib/plugins/odp_manager/index.node.ts

@@ -64,7 +64,7 @@ export class NodeOdpManager extends OdpManager {
     clientEngine = clientEngine || NODE_CLIENT_ENGINE;
     clientVersion = clientVersion || CLIENT_VERSION;
 
-    let odpConfig : OdpConfig | undefined = undefined;
+    let odpConfig: OdpConfig | undefined = undefined;
     if (odpIntegrationConfig?.integrated) {
       odpConfig = odpIntegrationConfig.odpConfig;
     }
@@ -87,10 +87,10 @@ export class NodeOdpManager extends OdpManager {
     } else {
       segmentManager = new OdpSegmentManager(
         odpOptions?.segmentsCache ||
-          new ServerLRUCache<string, string[]>({
-            maxSize: odpOptions?.segmentsCacheSize,
-            timeout: odpOptions?.segmentsCacheTimeout,
-          }),
+        new ServerLRUCache<string, string[]>({
+          maxSize: odpOptions?.segmentsCacheSize,
+          timeout: odpOptions?.segmentsCacheTimeout,
+        }),
         new OdpSegmentApiManager(customSegmentRequestHandler, logger),
         logger,
         odpConfig
@@ -133,8 +133,8 @@ export class NodeOdpManager extends OdpManager {
       logger,
     });
   }
-  
+
   registerVuid(vuid: string | undefined): void {
     this.logger.log(LogLevel.ERROR, `Unable to registerVuid ${vuid || ''} in a node server context`);
   }
-}
+}

lib/plugins/vuid_manager/index.ts

@@ -111,6 +111,7 @@ export class VuidManager implements IVuidManager {
   async initialize(): Promise<void> {
     if (!this.vuidEnabled) {
       await this.cache.remove(this._keyForVuid);
+      return;
     }
 
     if (!this._vuid) {
@@ -168,13 +169,4 @@ export class VuidManager implements IVuidManager {
    * @returns *true* if the VisitorId is valid otherwise *false* for invalid
    */
   static isVuid = (vuid: string | undefined): boolean => vuid?.startsWith(VuidManager.vuid_prefix) || false;
-
-  /**
-   * Function used in unit testing to reset the VuidManager
-   * **Important**: This should not to be used in production code
-   * @private
-   */
-  private _reset(): void {
-    this._vuid = '';
-  }
 }