upd

Author: raju-opti

lib/core/decision_service/index.tests.js

@@ -34,6 +34,7 @@ import AudienceEvaluator from '../audience_evaluator';
 import eventDispatcher from '../../event_processor/event_dispatcher/default_dispatcher.browser';
 import * as jsonSchemaValidator from '../../utils/json_schema_validator';
 import { getMockProjectConfigManager } from '../../tests/mock/mock_project_config_manager';
+import { Value } from '../../utils/promise/operation_value';
 
 import {
   getTestProjectConfig,
@@ -1207,10 +1208,10 @@ describe('lib/core/decision_service', function() {
       var sandbox;
       var mockLogger = createLogger({ logLevel: LOG_LEVEL.INFO });
       var fakeDecisionResponseWithArgs;
-      var fakeDecisionResponse = {
-        result: null,
+      var fakeDecisionResponse = Value.of('sync', {
+        result: {},
         reasons: [],
-      };
+      });
       var user;
       beforeEach(function() {
         configObj = projectConfig.createProjectConfig(cloneDeep(testDataWithFeatures));
@@ -1247,10 +1248,10 @@ describe('lib/core/decision_service', function() {
                 test_attribute: 'test_value',
               },
             });
-            fakeDecisionResponseWithArgs = {
-              result: 'variation',
+            fakeDecisionResponseWithArgs = Value.of('sync', {
+              result: { variationKey: 'variation' },
               reasons: [],
-            };
+            });
             experiment = configObj.experimentIdMap['594098'];
             getVariationStub = sandbox.stub(decisionServiceInstance, 'resolveVariation');
             getVariationStub.returns(fakeDecisionResponse);
@@ -1316,10 +1317,10 @@ describe('lib/core/decision_service', function() {
               optimizely: {},
               userId: 'user1',
             });
-            fakeDecisionResponseWithArgs = {
-              result: 'var',
+            fakeDecisionResponseWithArgs = Value.of('sync', {
+              result: { variationKey: 'var' },
               reasons: [],
-            };
+            });
             getVariationStub = sandbox.stub(decisionServiceInstance, 'resolveVariation');
             getVariationStub.returns(fakeDecisionResponseWithArgs);
             getVariationStub.withArgs(configObj, 'exp_with_group', user).returns(fakeDecisionResponseWithArgs);
@@ -1566,10 +1567,10 @@ describe('lib/core/decision_service', function() {
         var feature;
         var getVariationStub;
         var bucketStub;
-        fakeDecisionResponse = {
-          result: null,
+        fakeDecisionResponse = Value.of('sync', {
+          result: {},
           reasons: [],
-        };
+        });
         var fakeBucketStubDecisionResponse = {
           result: '599057',
           reasons: [],

lib/core/decision_service/index.ts

@@ -1635,6 +1635,11 @@ export class DecisionService {
     }
     const decisionVariationValue = this.resolveVariation(op, configObj, rule, user, decideOptions, userProfileTracker);
 
+    // console.log('decisionVariationValue', decisionVariationValue, decisionVariationValue.then);
+    if (!decisionVariationValue.then) {
+      console.log('errorrrr >>>>> ', flagKey, rule.key, decisionVariationValue);
+    }
+
     return decisionVariationValue.then((variationResult) => {
       decideReasons.push(...variationResult.reasons);
       return Value.of(op, {

package.json

@@ -53,7 +53,7 @@
     "clean:win": "(if exist dist rd /s/q dist)",
     "lint": "tsc --noEmit && eslint 'lib/**/*.js' 'lib/**/*.ts'",
     "test-vitest": "vitest run",
-    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r tsconfig-paths/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/*.tests.js'",
+    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r tsconfig-paths/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/decision_service/index.tests.js'",
     "test": "npm run test-mocha && npm run test-vitest",
     "posttest": "npm run lint",
     "test-ci": "npm run test-xbrowser && npm run test-umdbrowser",