upd

Author: raju-opti

lib/index.browser.tests.js

@@ -543,38 +543,6 @@ describe('javascript-sdk (Browser)', function() {
       //   );
       // });
 
-      // it('should log a warning when attempting to use an event batch size other than 1', async () => {
-      //   const config = createProjectConfig(testData.getTestProjectConfigWithFeatures());
-      //   const projectConfigManager = getMockProjectConfigManager({
-      //     initConfig: config,
-      //     onRunning: Promise.resolve(),
-      //   });
-
-      //   const client = optimizelyFactory.createInstance({
-      //     projectConfigManager,
-      //     errorHandler: fakeErrorHandler,
-      //     eventDispatcher: fakeEventDispatcher,
-      //     eventBatchSize: null,
-      //     logger,
-      //     odpOptions: {
-      //       eventBatchSize: 5,
-      //     },
-      //   });
-
-      //   projectConfigManager.pushUpdate(config);
-
-      //   await client.onReady();
-
-      //   client.sendOdpEvent(ODP_EVENT_ACTION.INITIALIZED);
-
-      //   sinon.assert.calledWith(
-      //     logger.log,
-      //     optimizelyFactory.enums.LOG_LEVEL.WARNING,
-      //     'ODP event batch size must be 1 in the browser.'
-      //   );
-      //   assert(client.odpManager.eventManager.batchSize, 1);
-      // });
-
       // it('should send odp client_initialized on client instantiation', async () => {
       //   const odpConfig = new OdpConfig('key', 'host', 'pixel', []);
       //   const apiManager = new BrowserOdpEventApiManager(mockRequestHandler, logger);

lib/optimizely/index.spec.ts

@@ -25,8 +25,9 @@ import testData from '../tests/test_data';
 import { getForwardingEventProcessor } from '../event_processor/forwarding_event_processor';
 import { LoggerFacade } from '../modules/logging';
 import { createProjectConfig } from '../project_config/project_config';
+import { getMockLogger } from '../tests/mock/mock_logger';
 
-describe('lib/optimizely', () => {
+describe('Optimizely', () => {
   const errorHandler = { handleError: function() {} };
 
   const eventDispatcher = {
@@ -35,18 +36,9 @@ describe('lib/optimizely', () => {
 
   const eventProcessor = getForwardingEventProcessor(eventDispatcher);
 
-  const createdLogger: LoggerFacade = {
-    ...logger.createLogger({
-      logLevel: LOG_LEVEL.INFO,
-    }),
-    info: () => {},
-    debug: () => {},
-    warn: () => {},
-    error: () => {},
-    log: () => {},
-  };
+  const logger = getMockLogger();
 
-  const notificationCenter = createNotificationCenter({ logger: createdLogger, errorHandler });
+  const notificationCenter = createNotificationCenter({ logger, errorHandler });
 
   it('should pass ssr to the project config manager', () => {
     const projectConfigManager = getMockProjectConfigManager({
@@ -60,7 +52,7 @@ describe('lib/optimizely', () => {
       projectConfigManager,
       errorHandler,
       jsonSchemaValidator,
-      logger: createdLogger,
+      logger,
       notificationCenter,
       eventProcessor,
       isSsr: true,