[FSSDK-10766] test additions

Author: junaed-optimizely

lib/core/decision_service/index.ts

@@ -562,7 +562,7 @@ export class DecisionService {
     if (!this.userProfileService || !userProfileTracker?.userProfile || !userProfileTracker.isProfileUpdated) {
       return;
     }
-
+    console.log('Hitting save user profile', userId)
     try {
       this.userProfileService.save({
         user_id: userId,
@@ -594,6 +594,7 @@ export class DecisionService {
     featureFlags: FeatureFlag[],
     user: OptimizelyUserContext,
     options: { [key: string]: boolean } = {}): DecisionResponse<DecisionObj>[] {
+      console.log('get variation for feature list is called', featureFlags)
     const userId = user.getUserId();
     const attributes = user.getAttributes();
     const decisions: DecisionResponse<DecisionObj>[] = [];

lib/optimizely/index.tests.js

@@ -5903,6 +5903,69 @@ describe('lib/optimizely', function() {
         assert.deepEqual(decision, expectedDecision);
         sinon.assert.calledTwice(eventDispatcher.dispatchEvent);
       });
+      describe('UPS Batching', function() {
+        var userProfileServiceInstance = {
+          lookup: function() {},
+          save: function() {},
+        };
+        beforeEach(function() {
+          optlyInstance = new Optimizely({
+            clientEngine: 'node-sdk',
+            datafile: testData.getTestDecideProjectConfig(),
+            userProfileService: userProfileServiceInstance,
+            errorHandler: errorHandler,
+            eventDispatcher: eventDispatcher,
+            jsonSchemaValidator: jsonSchemaValidator,
+            logger: createdLogger,
+            isValidInstance: true,
+            eventBatchSize: 1,
+            defaultDecideOptions: [],
+            notificationCenter,
+            eventProcessor,
+          });
+
+          sinon.stub(optlyInstance.decisionService.userProfileService, 'lookup') 
+          sinon.stub(optlyInstance.decisionService.userProfileService, 'save') 
+        });
+
+        it('Should call UPS methods only once', function() {
+          var flagKeysArray = ['feature_1', 'feature_2'];
+          var user = optlyInstance.createUserContext(userId);
+          var expectedVariables1 = optlyInstance.getAllFeatureVariables(flagKeysArray[0], userId);
+          var expectedVariables2 = optlyInstance.getAllFeatureVariables(flagKeysArray[1], userId);
+          optlyInstance.decisionService.userProfileService.save.resetHistory();
+          optlyInstance.decisionService.userProfileService.lookup.resetHistory();
+          var decisionsMap = optlyInstance.decideForKeys(user, flagKeysArray);
+          var decision1 = decisionsMap[flagKeysArray[0]];
+          var decision2 = decisionsMap[flagKeysArray[1]];
+          var expectedDecision1 = {
+            variationKey: '18257766532',
+            enabled: true,
+            variables: expectedVariables1,
+            ruleKey: '18322080788',
+            flagKey: flagKeysArray[0],
+            userContext: user,
+            reasons: [],
+          };
+          var expectedDecision2 = {
+            variationKey: 'variation_with_traffic',
+            enabled: true,
+            variables: expectedVariables2,
+            ruleKey: 'exp_no_audience',
+            flagKey: flagKeysArray[1],
+            userContext: user,
+            reasons: [],
+          };
+
+          assert.deepEqual(Object.values(decisionsMap).length, 2);
+          assert.deepEqual(decision1, expectedDecision1);
+          assert.deepEqual(decision2, expectedDecision2);
+          // UPS batch assertion
+          sinon.assert.calledOnce(optlyInstance.decisionService.userProfileService.lookup);
+          sinon.assert.calledOnce(optlyInstance.decisionService.userProfileService.save);
+        });
+      })
+      
     });
 
     describe('#decideAll', function() {
@@ -6096,6 +6159,69 @@ describe('lib/optimizely', function() {
           sinon.assert.calledThrice(eventDispatcher.dispatchEvent);
         });
       });
+
+      describe('UPS batching', function() {
+        beforeEach(function() {
+          var userProfileServiceInstance = {
+            lookup: function() {},
+            save: function() {},
+          };
+
+          optlyInstance = new Optimizely({
+            clientEngine: 'node-sdk',
+            datafile: testData.getTestDecideProjectConfig(),
+            userProfileService: userProfileServiceInstance,
+            errorHandler: errorHandler,
+            eventDispatcher: eventDispatcher,
+            jsonSchemaValidator: jsonSchemaValidator,
+            logger: createdLogger,
+            isValidInstance: true,
+            eventBatchSize: 1,
+            defaultDecideOptions: [OptimizelyDecideOption.ENABLED_FLAGS_ONLY],
+            eventProcessor,
+            notificationCenter,
+          });
+
+          sinon.stub(optlyInstance.decisionService.userProfileService, 'lookup')
+          sinon.stub(optlyInstance.decisionService.userProfileService, 'save')
+        });
+
+        it('should call UPS methods only once', function() {
+          var flagKey1 = 'feature_1';
+          var flagKey2 = 'feature_2';
+          var user = optlyInstance.createUserContext(userId, { gender: 'female' });
+          var decisionsMap = optlyInstance.decideAll(user, [OptimizelyDecideOption.EXCLUDE_VARIABLES]);
+          var decision1 = decisionsMap[flagKey1];
+          var decision2 = decisionsMap[flagKey2];
+          var expectedDecision1 = {
+            variationKey: '18257766532',
+            enabled: true,
+            variables: {},
+            ruleKey: '18322080788',
+            flagKey: flagKey1,
+            userContext: user,
+            reasons: [],
+          };
+          var expectedDecision2 = {
+            variationKey: 'variation_with_traffic',
+            enabled: true,
+            variables: {},
+            ruleKey: 'exp_no_audience',
+            flagKey: flagKey2,
+            userContext: user,
+            reasons: [],
+          };
+          
+          // Decision assertion
+          assert.deepEqual(Object.values(decisionsMap).length, 2);
+          assert.deepEqual(decision1, expectedDecision1);
+          assert.deepEqual(decision2, expectedDecision2);
+          
+          // UPS batch assertion
+          sinon.assert.calledOnce(optlyInstance.decisionService.userProfileService.lookup);
+          sinon.assert.calledOnce(optlyInstance.decisionService.userProfileService.save);
+        })
+      });
     });
   });