event tag

Author: raju-opti

lib/core/bucketer/index.tests.js

@@ -29,7 +29,6 @@ import {
   USER_NOT_IN_ANY_EXPERIMENT,
   USER_ASSIGNED_TO_EXPERIMENT_BUCKET,
 } from '.';
-import { mock } from 'node:test';
 
 var buildLogMessageFromArgs = args => sprintf(args[1], ...args.splice(2));
 var testData = getTestProjectConfig();

lib/utils/event_tag_utils/index.tests.js

@@ -18,15 +18,23 @@ import { assert } from 'chai';
 import { sprintf } from '../../utils/fns';
 
 import * as eventTagUtils from './';
+import { FAILED_TO_PARSE_REVENUE, PARSED_REVENUE_VALUE, PARSED_NUMERIC_VALUE, FAILED_TO_PARSE_VALUE } from '../../log_messages';
 
 var buildLogMessageFromArgs = args => sprintf(args[1], ...args.splice(2));
 
+var createLogger = () => ({
+  debug: () => {},
+  info: () => {},
+  warn: () => {},
+  error: () => {},
+  child: () => createLogger(),
+})
+
 describe('lib/utils/event_tag_utils', function() {
   var mockLogger;
   beforeEach(function() {
-    mockLogger = {
-      log: sinon.stub(),
-    };
+    mockLogger = createLogger();
+    sinon.stub(mockLogger, 'info');
   });
 
   describe('APIs', function() {
@@ -41,8 +49,9 @@ describe('lib/utils/event_tag_utils', function() {
           );
 
           assert.strictEqual(parsedRevenueValue, 1337);
-          var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
-          assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Parsed revenue value "1337" from event tags.');
+
+          assert.strictEqual(mockLogger.info.args[0][0], PARSED_REVENUE_VALUE);
+          assert.strictEqual(mockLogger.info.args[0][1], 1337);
 
           // test out a float
           parsedRevenueValue = eventTagUtils.getRevenueValue(
@@ -67,8 +76,8 @@ describe('lib/utils/event_tag_utils', function() {
 
           assert.strictEqual(parsedRevenueValue, null);
 
-          var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
-          assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Failed to parse revenue value "invalid" from event tags.');
+          assert.strictEqual(mockLogger.info.args[0][0], FAILED_TO_PARSE_REVENUE);
+          assert.strictEqual(mockLogger.info.args[0][1], 'invalid');
         });
       });
 
@@ -97,8 +106,9 @@ describe('lib/utils/event_tag_utils', function() {
           );
 
           assert.strictEqual(parsedEventValue, 1337);
-          var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
-          assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Parsed event value "1337" from event tags.');
+
+          assert.strictEqual(mockLogger.info.args[0][0], PARSED_NUMERIC_VALUE);
+          assert.strictEqual(mockLogger.info.args[0][1], 1337);
 
           // test out a float
           parsedEventValue = eventTagUtils.getEventValue(
@@ -123,8 +133,8 @@ describe('lib/utils/event_tag_utils', function() {
 
           assert.strictEqual(parsedEventValue, null);
 
-          var logMessage = buildLogMessageFromArgs(mockLogger.log.args[0]);
-          assert.strictEqual(logMessage, 'EVENT_TAG_UTILS: Failed to parse event value "invalid" from event tags.');
+          assert.strictEqual(mockLogger.info.args[0][0], FAILED_TO_PARSE_VALUE);
+          assert.strictEqual(mockLogger.info.args[0][1], 'invalid');
         });
       });
 

package.json

@@ -74,7 +74,7 @@
     "clean:win": "(if exist dist rd /s/q dist)",
     "lint": "tsc --noEmit && eslint 'lib/**/*.js' 'lib/**/*.ts'",
     "test-vitest": "tsc --noEmit --p tsconfig.spec.json && vitest run",
-    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/odp_segment_condition_evaluator/index.tests.js'",
+    "test-mocha": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/event_tag_utils/*.tests.js'",
     "test": "npm run test-mocha && npm run test-vitest",
     "posttest": "npm run lint",
     "test-ci": "npm run test-xbrowser && npm run test-umdbrowser",