update

Author: raju-opti

lib/modules/datafile-manager/httpPollingDatafileManager.ts

@@ -115,7 +115,7 @@ export default abstract class HttpPollingDatafileManager implements DatafileMana
       urlTemplate = DEFAULT_URL_TEMPLATE,
       cache = noOpKeyValueCache,
     } = configWithDefaultsApplied;
-
+    console.log('cache is ', cache, cache.get.toString());
     this.cache = cache;
     this.cacheKey = 'opt-datafile-' + sdkKey;
     this.sdkKey = sdkKey;
@@ -339,6 +339,7 @@ export default abstract class HttpPollingDatafileManager implements DatafileMana
 
   setDatafileFromCacheIfAvailable(): void {
     this.cache.get(this.cacheKey).then(datafile => {
+      console.log('datafile is ..', datafile);
       if (this.isStarted && !this.isReadyPromiseSettled && datafile) {
         logger.debug('Using datafile from cache');
         this.currentDatafile = datafile;

package-lock.json

@@ -73,7 +73,7 @@
     "clean": "rm -rf dist",
     "clean:win": "(if exist dist rd /s/q dist)",
     "lint": "tsc --noEmit && eslint 'lib/**/*.js' 'lib/**/*.ts'",
-    "testvite": "vitest",
+    "testvite": "tsc --noEmit --p tsconfig.spec.json && vitest",
     "test": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\" }' mocha -r ts-node/register -r lib/tests/exit_on_unhandled_rejection.js 'lib/**/*.tests.ts' 'lib/**/*.tests.js' && jest",
     "posttest": "npm run lint",
     "test-ci": "npm run test-xbrowser && npm run test-umdbrowser",
@@ -129,6 +129,7 @@
     "eslint": "^8.21.0",
     "eslint-config-prettier": "^6.10.0",
     "eslint-plugin-prettier": "^3.1.2",
+    "happy-dom": "^14.12.3",
     "jest-environment-jsdom": "^29.0.0",
     "jest-localstorage-mock": "^2.4.22",
     "json-loader": "^0.5.4",

package.json

@@ -1,7 +1,7 @@
 {
     "typeAcquisition": {
         "include": [
-            "jest"
+            "vitest"
         ]
     }
 }

tests/jsconfig.json renamed to tests/_jsconfig.json

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { describe, beforeEach, afterEach, it, expect, vi } from 'vitest';
+import { describe, beforeEach, afterEach, beforeAll, it, expect, vi, MockInstance } from 'vitest';
 
 import HttpPollingDatafileManager from '../lib/modules/datafile-manager/httpPollingDatafileManager';
 import { Headers, AbortableRequest, Response } from '../lib/modules/datafile-manager/http';
@@ -23,16 +23,17 @@ import PersistentKeyValueCache from '../lib/plugins/key_value_cache/persistentKe
 
 
 vi.mock('../lib/modules/datafile-manager/backoffController', () => {
-  return vi.fn().mockImplementation(() => {
-    const getDelayMock = vi.fn().mockImplementation(() => 0);
-    return {
-      getDelay: getDelayMock,
-      countError: vi.fn(),
-      reset: vi.fn(),
-    };
-  });
+  const MockBackoffController = vi.fn();
+  MockBackoffController.prototype.getDelay = vi.fn().mockImplementation(() => 0);
+  MockBackoffController.prototype.countError = vi.fn();
+  MockBackoffController.prototype.reset = vi.fn();
+
+  return {
+    'default': MockBackoffController,
+  }
 });
 
+
 import BackoffController from '../lib/modules/datafile-manager/backoffController';
 import { LoggerFacade, getLogger } from '../lib/modules/logging';
 import { resetCalls, spy, verify } from 'ts-mockito';
@@ -481,7 +482,7 @@ describe('httpPollingDatafileManager', () => {
 
         describe('backoff', () => {
           it('uses the delay from the backoff controller getDelay method when greater than updateInterval', async () => {
-            const BackoffControllerMock = (BackoffController as unknown) as vi.Mock<BackoffController, []>;
+            const BackoffControllerMock = (BackoffController as unknown) as MockInstance<() => BackoffController>;
             const getDelayMock = BackoffControllerMock.mock.results[0].value.getDelay;
             getDelayMock.mockImplementationOnce(() => 5432);
 
@@ -513,7 +514,7 @@ describe('httpPollingDatafileManager', () => {
             });
             manager.start();
             await manager.responsePromises[0];
-            const BackoffControllerMock = (BackoffController as unknown) as vi.Mock<BackoffController, []>;
+            const BackoffControllerMock = (BackoffController as unknown) as MockInstance<() => BackoffController>;
             expect(BackoffControllerMock.mock.results[0].value.countError).toBeCalledTimes(1);
           });
 
@@ -525,7 +526,7 @@ describe('httpPollingDatafileManager', () => {
             } catch (e) {
               //empty
             }
-            const BackoffControllerMock = (BackoffController as unknown) as vi.Mock<BackoffController, []>;
+            const BackoffControllerMock = (BackoffController as unknown) as MockInstance<() => BackoffController>;
             expect(BackoffControllerMock.mock.results[0].value.countError).toBeCalledTimes(1);
           });
 
@@ -538,15 +539,15 @@ describe('httpPollingDatafileManager', () => {
               },
             });
             manager.start();
-            const BackoffControllerMock = (BackoffController as unknown) as vi.Mock<BackoffController, []>;
+            const BackoffControllerMock = (BackoffController as unknown) as MockInstance<() => BackoffController>;
             // Reset is called in start - we want to check that it is also called after the response, so reset the mock here
             BackoffControllerMock.mock.results[0].value.reset.mockReset();
             await manager.onReady();
             expect(BackoffControllerMock.mock.results[0].value.reset).toBeCalledTimes(1);
           });
 
           it('resets the backoff controller when start is called', async () => {
-            const BackoffControllerMock = (BackoffController as unknown) as vi.Mock<BackoffController, []>;
+            const BackoffControllerMock = (BackoffController as unknown) as MockInstance<() => BackoffController>;
             manager.start();
             expect(BackoffControllerMock.mock.results[0].value.reset).toBeCalledTimes(1);
             try {

tests/httpPollingDatafileManager.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+import { describe, beforeEach, afterEach, beforeAll, it, expect, vi, MockInstance } from 'vitest';
 
 import { resetCalls, spy, verify } from 'ts-mockito';
 import { LogLevel, LoggerFacade, getLogger, setLogLevel } from '../lib/modules/logging';

tests/httpPollingDatafileManagerPolling.spec.ts

@@ -13,7 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-/// <reference types="jest" />
+import { describe, beforeEach, afterEach, it, expect, vi } from 'vitest';
+
 import * as logging from '../lib/modules/logging/logger';
 import * as eventProcessor from '../lib//plugins/event_processor/index.react_native';
 
@@ -24,17 +25,18 @@ import optimizelyFactory from '../lib/index.react_native';
 import configValidator from '../lib/utils/config_validator';
 import eventProcessorConfigValidator from '../lib/utils/event_processor_config_validator';
 
-jest.mock('react-native-get-random-values')
-jest.mock('fast-text-encoding')
+vi.mock('@react-native-community/netinfo');
+vi.mock('react-native-get-random-values')
+vi.mock('fast-text-encoding')
 
 describe('javascript-sdk/react-native', () => {
   beforeEach(() => {
-    jest.spyOn(optimizelyFactory.eventDispatcher, 'dispatchEvent');
-    jest.useFakeTimers();
+    vi.spyOn(optimizelyFactory.eventDispatcher, 'dispatchEvent');
+    vi.useFakeTimers();
   });
 
   afterEach(() => {
-    jest.resetAllMocks();
+    vi.resetAllMocks();
   });
 
   describe('APIs', () => {
@@ -56,14 +58,14 @@ describe('javascript-sdk/react-native', () => {
       beforeEach(() => {
         // @ts-ignore
         silentLogger = optimizelyFactory.logging.createLogger();
-        jest.spyOn(console, 'error');
-        jest.spyOn(configValidator, 'validate').mockImplementation(() => {
+        vi.spyOn(console, 'error');
+        vi.spyOn(configValidator, 'validate').mockImplementation(() => {
           throw new Error('Invalid config or something');
         });
       });
 
       afterEach(() => {
-        jest.resetAllMocks();
+        vi.resetAllMocks();
       });
 
       it('should not throw if the provided config is not valid', () => {
@@ -131,11 +133,11 @@ describe('javascript-sdk/react-native', () => {
 
       describe('when passing in logLevel', () => {
         beforeEach(() => {
-          jest.spyOn(logging, 'setLogLevel');
+          vi.spyOn(logging, 'setLogLevel');
         });
 
         afterEach(() => {
-          jest.resetAllMocks();
+          vi.resetAllMocks();
         });
 
         it('should call logging.setLogLevel', () => {
@@ -150,11 +152,11 @@ describe('javascript-sdk/react-native', () => {
 
       describe('when passing in logger', () => {
         beforeEach(() => {
-          jest.spyOn(logging, 'setLogHandler');
+          vi.spyOn(logging, 'setLogHandler');
         });
 
         afterEach(() => {
-          jest.resetAllMocks();
+          vi.resetAllMocks();
         });
 
         it('should call logging.setLogHandler with the supplied logger', () => {
@@ -173,11 +175,11 @@ describe('javascript-sdk/react-native', () => {
         // @ts-ignore
         let eventProcessorSpy;
         beforeEach(() => {
-          eventProcessorSpy = jest.spyOn(eventProcessor, 'createEventProcessor');
+          eventProcessorSpy = vi.spyOn(eventProcessor, 'createEventProcessor');
         });
 
         afterEach(() => {
-          jest.resetAllMocks();
+          vi.resetAllMocks();
         });
 
         it('should use default event flush interval when none is provided', () => {
@@ -201,11 +203,11 @@ describe('javascript-sdk/react-native', () => {
 
         describe('with an invalid flush interval', () => {
           beforeEach(() => {
-            jest.spyOn(eventProcessorConfigValidator, 'validateEventFlushInterval').mockImplementation(() => false);
+            vi.spyOn(eventProcessorConfigValidator, 'validateEventFlushInterval').mockImplementation(() => false);
           });
 
           afterEach(() => {
-            jest.resetAllMocks();
+            vi.resetAllMocks();
           });
 
           it('should ignore the event flush interval and use the default instead', () => {
@@ -231,11 +233,11 @@ describe('javascript-sdk/react-native', () => {
 
         describe('with a valid flush interval', () => {
           beforeEach(() => {
-            jest.spyOn(eventProcessorConfigValidator, 'validateEventFlushInterval').mockImplementation(() => true);
+            vi.spyOn(eventProcessorConfigValidator, 'validateEventFlushInterval').mockImplementation(() => true);
           });
 
           afterEach(() => {
-            jest.resetAllMocks();
+            vi.resetAllMocks();
           });
 
           it('should use the provided event flush interval', () => {
@@ -278,11 +280,11 @@ describe('javascript-sdk/react-native', () => {
 
         describe('with an invalid event batch size', () => {
           beforeEach(() => {
-            jest.spyOn(eventProcessorConfigValidator, 'validateEventBatchSize').mockImplementation(() => false);
+            vi.spyOn(eventProcessorConfigValidator, 'validateEventBatchSize').mockImplementation(() => false);
           });
 
           afterEach(() => {
-            jest.resetAllMocks();
+            vi.resetAllMocks();
           });
 
           it('should ignore the event batch size and use the default instead', () => {
@@ -308,11 +310,11 @@ describe('javascript-sdk/react-native', () => {
 
         describe('with a valid event batch size', () => {
           beforeEach(() => {
-            jest.spyOn(eventProcessorConfigValidator, 'validateEventBatchSize').mockImplementation(() => true);
+            vi.spyOn(eventProcessorConfigValidator, 'validateEventBatchSize').mockImplementation(() => true);
           });
 
           afterEach(() => {
-            jest.resetAllMocks();
+            vi.resetAllMocks();
           });
 
           it('should use the provided event batch size', () => {