Skip to content

Commit b24cdc9

Browse files
committed
review
1 parent ea1b2e0 commit b24cdc9

File tree

4 files changed

+18
-52
lines changed

4 files changed

+18
-52
lines changed

lib/export_types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2022-2023, Optimizely
2+
* Copyright 2022-2024, Optimizely
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.

lib/notification_center/index.tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/****************************************************************************
2-
* Copyright 2020, Optimizely, Inc. and contributors *
2+
* Copyright 2020, 2024, Optimizely, Inc. and contributors *
33
* *
44
* Licensed under the Apache License, Version 2.0 (the "License"); *
55
* you may not use this file except in compliance with the License. *

lib/notification_center/type.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
/**
2+
* Copyright 2024, Optimizely
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
117
import { LogEvent } from '../event_processor/event_dispatcher/event_dispatcher';
218
import { EventTags, Experiment, UserAttributes, Variation } from '../shared_types';
319

lib/utils/enums/index.ts

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -285,56 +285,6 @@ export const DECISION_MESSAGES = {
285285
VARIABLE_VALUE_INVALID: 'Variable value for key "%s" is invalid or wrong type.',
286286
};
287287

288-
/*
289-
* Notification types for use with NotificationCenter
290-
* Format is EVENT: <list of parameters to callback>
291-
*
292-
* SDK consumers can use these to register callbacks with the notification center.
293-
*
294-
* @deprecated since 3.1.0
295-
* ACTIVATE: An impression event will be sent to Optimizely
296-
* Callbacks will receive an object argument with the following properties:
297-
* - experiment {Object}
298-
* - userId {string}
299-
* - attributes {Object|undefined}
300-
* - variation {Object}
301-
* - logEvent {Object}
302-
*
303-
* DECISION: A decision is made in the system. i.e. user activation,
304-
* feature access or feature-variable value retrieval
305-
* Callbacks will receive an object argument with the following properties:
306-
* - type {string}
307-
* - userId {string}
308-
* - attributes {Object|undefined}
309-
* - decisionInfo {Object|undefined}
310-
*
311-
* LOG_EVENT: A batch of events, which could contain impressions and/or conversions,
312-
* will be sent to Optimizely
313-
* Callbacks will receive an object argument with the following properties:
314-
* - url {string}
315-
* - httpVerb {string}
316-
* - params {Object}
317-
*
318-
* OPTIMIZELY_CONFIG_UPDATE: This Optimizely instance has been updated with a new
319-
* config
320-
*
321-
* TRACK: A conversion event will be sent to Optimizely
322-
* Callbacks will receive the an object argument with the following properties:
323-
* - eventKey {string}
324-
* - userId {string}
325-
* - attributes {Object|undefined}
326-
* - eventTags {Object|undefined}
327-
* - logEvent {Object}
328-
*
329-
*/
330-
// export enum NOTIFICATION_TYPES {
331-
// ACTIVATE = 'ACTIVATE:experiment, user_id,attributes, variation, event',
332-
// DECISION = 'DECISION:type, userId, attributes, decisionInfo',
333-
// LOG_EVENT = 'LOG_EVENT:logEvent',
334-
// OPTIMIZELY_CONFIG_UPDATE = 'OPTIMIZELY_CONFIG_UPDATE',
335-
// TRACK = 'TRACK:event_key, user_id, attributes, event_tags, event',
336-
// }
337-
338288
export { NOTIFICATION_TYPES } from '../../notification_center/type';
339289

340290
/**

0 commit comments

Comments
 (0)