Skip to content

Commit cb7999b

Browse files
authored
fix: removed react native async storage package from utils. (#536)
Summary: Keeping React Native specific implementation in utils makes optimizely-sdk expect react native peer dependencies installed even in case of browser and node. Removed React Native specific cache implementation from utils. Test plan: All Existing tests should pass
1 parent dae32e0 commit cb7999b

File tree

7 files changed

+1
-248
lines changed

7 files changed

+1
-248
lines changed

packages/utils/__mocks__/@react-native-community/async-storage.ts

Lines changed: 0 additions & 37 deletions
This file was deleted.

packages/utils/__tests__/reactNativeAsyncStorageCache.spec.ts

Lines changed: 0 additions & 70 deletions
This file was deleted.

packages/utils/package-lock.json

Lines changed: 0 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/utils/package.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@
4545
"@types/uuid": "^3.4.4",
4646
"jest": "^23.6.0",
4747
"ts-jest": "^23.10.5",
48-
"typescript": "^3.3.3333",
49-
"@react-native-community/async-storage": "^1.2.0"
50-
},
51-
"peerDependencies": {
52-
"@react-native-community/async-storage": "^1.2.0"
48+
"typescript": "^3.3.3333"
5349
}
5450
}

packages/utils/src/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,3 @@ export enum NOTIFICATION_TYPES {
155155
export interface NotificationCenter {
156156
sendNotifications(notificationType: NOTIFICATION_TYPES, notificationData?: any): void
157157
}
158-
159-
export { default as PersistentKeyValueCache } from './persistentKeyValueCache'
160-
export { default as ReactNativeAsyncStorageCache } from './reactNativeAsyncStorageCache'

packages/utils/src/persistentKeyValueCache.ts

Lines changed: 0 additions & 60 deletions
This file was deleted.

packages/utils/src/reactNativeAsyncStorageCache.ts

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)