[FSSDK-10935] log adjustment after merge

Author: junaed-optimizely

lib/error_messages.ts

@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export const BROWSER_ODP_MANAGER_INITIALIZATION_FAILED = '%s: Error initializing Browser ODP Manager.';
 export const CONDITION_EVALUATOR_ERROR = '%s: Error evaluating audience condition of type %s: %s';
 export const DATAFILE_AND_SDK_KEY_MISSING =

lib/exception_messages.ts

@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export const FAILED_TO_DISPATCH_EVENTS = 'Failed to dispatch events'
 export const FAILED_TO_DISPATCH_EVENTS_WITH_ARG = 'Failed to dispatch events: %s';
 export const EVENT_PROCESSOR_STOPPED = 'Event processor stopped before it could be started';

lib/log_messages.ts

@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 export const ACTIVATE_USER = '%s: Activating user %s in experiment %s.';
 export const DISPATCH_CONVERSION_EVENT = '%s: Dispatching conversion event to URL %s with params %s.';
 export const DISPATCH_IMPRESSION_EVENT = '%s: Dispatching impression event to URL %s with params %s.';

lib/notification_center/index.ts

@@ -18,7 +18,6 @@ import { objectValues } from '../utils/fns';
 
 import {
   LOG_LEVEL,
-  LOG_MESSAGES,
 } from '../utils/enums';
 
 import { NOTIFICATION_TYPES } from './type';
@@ -112,7 +111,7 @@ export class DefaultNotificationCenter implements NotificationCenter, Notificati
       } catch (ex: any) {
         this.logger.log(
           LOG_LEVEL.ERROR,
-          LOG_MESSAGES.NOTIFICATION_LISTENER_EXCEPTION,
+          NOTIFICATION_LISTENER_EXCEPTION,
           MODULE_NAME,
           notificationType,
           ex.message,

lib/odp/event_manager/odp_event_manager.ts

@@ -22,8 +22,8 @@ import { BackoffController, Repeater } from '../../utils/repeater/repeater';
 import { Producer } from '../../utils/type';
 import { runWithRetry } from '../../utils/executor/backoff_retry_runner';
 import { isSuccessStatusCode } from '../../utils/http_request_handler/http_util';
-import { ERROR_MESSAGES } from '../../utils/enums';
 import { ODP_DEFAULT_EVENT_TYPE, ODP_USER_KEY } from '../constant';
+import { ODP_NOT_INTEGRATED } from '../../error_messages';
 
 export interface OdpEventManager extends Service {
   updateConfig(odpIntegrationConfig: OdpIntegrationConfig): void;
@@ -154,7 +154,7 @@ export class DefaultOdpEventManager extends BaseService implements OdpEventManag
     }
 
     if (!this.odpIntegrationConfig?.integrated) {
-       this.logger?.error(ERROR_MESSAGES.ODP_NOT_INTEGRATED);
+       this.logger?.error(ODP_NOT_INTEGRATED);
        return;
     }
 

lib/odp/segment_manager/odp_segment_manager.ts

@@ -14,13 +14,13 @@
  * limitations under the License.
  */
 
-import { ERROR_MESSAGES } from '../../utils/enums';
 import { Cache } from '../../utils/cache/cache';
 import { OdpSegmentApiManager } from './odp_segment_api_manager';
 import { OdpIntegrationConfig } from '../odp_config';
 import { OptimizelySegmentOption } from './optimizely_segment_option';
 import { ODP_USER_KEY } from '../constant';
 import { LoggerFacade } from '../../modules/logging';
+import { ODP_CONFIG_NOT_AVAILABLE, ODP_NOT_INTEGRATED } from '../../error_messages';
 
 export interface OdpSegmentManager {
   fetchQualifiedSegments(
@@ -61,12 +61,12 @@ export class DefaultOdpSegmentManager implements OdpSegmentManager {
     options?: Array<OptimizelySegmentOption>
   ): Promise<string[] | null> {
     if (!this.odpIntegrationConfig) {
-      this.logger?.warn(ERROR_MESSAGES.ODP_CONFIG_NOT_AVAILABLE);
+      this.logger?.warn(ODP_CONFIG_NOT_AVAILABLE);
       return null;      
     }
 
     if (!this.odpIntegrationConfig.integrated) {
-      this.logger?.warn(ERROR_MESSAGES.ODP_NOT_INTEGRATED);
+      this.logger?.warn(ODP_NOT_INTEGRATED);
       return null;
     }
 

lib/optimizely/index.spec.ts

@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import { describe, it, expect, vi } from 'vitest';
 import Optimizely from '.';
 import { getMockProjectConfigManager } from '../tests/mock/mock_project_config_manager';

lib/optimizely/index.tests.js

@@ -37,8 +37,43 @@ import { createNotificationCenter } from '../notification_center';
 import { createProjectConfig } from '../project_config/project_config';
 import { getMockProjectConfigManager } from '../tests/mock/mock_project_config_manager';
 import { DECISION_NOTIFICATION_TYPES } from '../notification_center/type';
+import {
+  AUDIENCE_EVALUATION_RESULT_COMBINED,
+  EVENT_KEY_NOT_FOUND,
+  EXPERIMENT_NOT_RUNNING,
+  FEATURE_HAS_NO_EXPERIMENTS,
+  FORCED_BUCKETING_FAILED,
+  INVALID_CLIENT_ENGINE,
+  INVALID_DEFAULT_DECIDE_OPTIONS,
+  INVALID_OBJECT,
+  NOT_ACTIVATING_USER,
+  NOT_TRACKING_USER,
+  RETURNING_STORED_VARIATION,
+  USER_BUCKETED_INTO_EXPERIMENT_IN_GROUP,
+  USER_DOESNT_MEET_CONDITIONS_FOR_TARGETING_RULE,
+  USER_FORCED_IN_VARIATION,
+  USER_HAS_FORCED_VARIATION,
+  USER_HAS_NO_FORCED_VARIATION,
+  USER_HAS_NO_FORCED_VARIATION_FOR_EXPERIMENT,
+  USER_HAS_NO_VARIATION,
+  USER_HAS_VARIATION,
+  USER_IN_ROLLOUT,
+  USER_MAPPED_TO_FORCED_VARIATION,
+  USER_MEETS_CONDITIONS_FOR_TARGETING_RULE,
+  USER_NOT_BUCKETED_INTO_TARGETING_RULE,
+  USER_NOT_IN_EXPERIMENT,
+  VARIATION_REMOVED_FOR_USER,
+} from '../log_messages';
+import {
+  EXPERIMENT_KEY_NOT_IN_DATAFILE,
+  INVALID_ATTRIBUTES,
+  INVALID_EXPERIMENT_KEY,
+  INVALID_INPUT_FORMAT,
+  NO_VARIATION_FOR_EXPERIMENT_KEY,
+  USER_NOT_IN_FORCED_VARIATION,
+} from '../error_messages';
+import { FAILED_TO_STOP, ONREADY_TIMEOUT_EXPIRED, PROMISE_SHOULD_NOT_HAVE_RESOLVED } from '../exception_messages';
 
-var ERROR_MESSAGES = enums.ERROR_MESSAGES;
 var LOG_LEVEL = enums.LOG_LEVEL;
 var DECISION_SOURCES = enums.DECISION_SOURCES;
 var DECISION_MESSAGES = enums.DECISION_MESSAGES;

lib/project_config/config_manager_factory.react_native.spec.ts

@@ -61,6 +61,7 @@ import { createPollingProjectConfigManager } from './config_manager_factory.reac
 import { BrowserRequestHandler } from '../utils/http_request_handler/browser_request_handler';
 import { AsyncStorageCache } from '../utils/cache/async_storage_cache.react_native';
 import { getMockSyncCache } from '../tests/mock/mock_cache';
+import { MODULE_NOT_FOUND_REACT_NATIVE_ASYNC_STORAGE } from '../exception_messages';
 
 describe('createPollingConfigManager', () => {
   const mockGetPollingConfigManager = vi.mocked(getPollingConfigManager);

lib/project_config/polling_datafile_manager.ts

@@ -23,6 +23,8 @@ import { RequestHandler, AbortableRequest, Headers, Response } from '../utils/ht
 import { Repeater } from '../utils/repeater/repeater';
 import { Consumer, Fn } from '../utils/type';
 import { isSuccessStatusCode } from '../utils/http_request_handler/http_util';
+import { DATAFILE_MANAGER_STOPPED, FAILED_TO_FETCH_DATAFILE } from '../exception_messages';
+import { DATAFILE_FETCH_REQUEST_FAILED, ERROR_FETCHING_DATAFILE } from '../error_messages';
 
 export class PollingDatafileManager extends BaseService implements DatafileManager {
   private requestHandler: RequestHandler;
@@ -96,7 +98,7 @@ export class PollingDatafileManager extends BaseService implements DatafileManag
     if (this.isNew() || this.isStarting()) {
       this.startPromise.reject(new Error(DATAFILE_MANAGER_STOPPED));
     }
-
+    // Todo: Replace this with constant
     this.logger?.debug('Datafile manager stopped');
     this.state = ServiceState.Terminated;
     this.repeater.stop();