review

raju-opti · raju-opti · commit d40119a631cf · 2024-11-21T22:11:39.000+06:00
diff --git a/lib/event_processor/batch_event_processor.react_native.spec.ts b/lib/event_processor/batch_event_processor.react_native.spec.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { vi, describe, it, expect, beforeEach } from 'vitest';
 
 const mockNetInfo = vi.hoisted(() => {
diff --git a/lib/event_processor/batch_event_processor.react_native.ts b/lib/event_processor/batch_event_processor.react_native.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import {
   NetInfoState,
   addEventListener as addConnectionListener,
diff --git a/lib/event_processor/batch_event_processor.ts b/lib/event_processor/batch_event_processor.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { EventProcessor, ProcessableEvent } from "./eventProcessor";
 import { Cache } from "../utils/cache/cache";
 import { EventDispatcher, EventDispatcherResponse, EventV1Request } from "./eventDispatcher";
diff --git a/lib/event_processor/eventProcessor.ts b/lib/event_processor/eventProcessor.ts
@@ -16,16 +16,12 @@
 import { ConversionEvent, ImpressionEvent } from './events'
 import { EventV1Request } from './eventDispatcher'
 import { getLogger } from '../modules/logging'
-import { NOTIFICATION_TYPES } from '../utils/enums'
-import { NotificationSender } from '../core/notification_center'
 import { Service } from '../service'
 import { Consumer, Fn } from '../utils/type';
 
 export const DEFAULT_FLUSH_INTERVAL = 30000 // Unit is ms - default flush interval is 30s
 export const DEFAULT_BATCH_SIZE = 10
 
-const logger = getLogger('EventProcessor')
-
 export type ProcessableEvent = ConversionEvent | ImpressionEvent
 
 export interface EventProcessor extends Service {
diff --git a/lib/event_processor/event_processor_factory.spec.ts b/lib/event_processor/event_processor_factory.spec.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { describe, it, expect, beforeEach, vi, MockInstance } from 'vitest';
 import { DEFAULT_EVENT_BATCH_SIZE, DEFAULT_EVENT_FLUSH_INTERVAL, DEFAULT_MAX_BACKOFF, DEFAULT_MIN_BACKOFF, getBatchEventProcessor } from './event_processor_factory';
 import { BatchEventProcessor, BatchEventProcessorConfig, EventWithId } from './batch_event_processor';
diff --git a/lib/event_processor/event_processor_factory.ts b/lib/event_processor/event_processor_factory.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { LogLevel } from "../common_exports";
 import { StartupLog } from "../service";
 import { ExponentialBackoff, IntervalRepeater } from "../utils/repeater/repeater";
diff --git a/lib/event_processor/forwarding_event_processor.spec.ts b/lib/event_processor/forwarding_event_processor.spec.ts
@@ -30,7 +30,6 @@ const getMockEventDispatcher = (): EventDispatcher => {
 describe('ForwardingEventProcessor', () => {
   it('should resolve onRunning() when start is called', async () => {
     const dispatcher = getMockEventDispatcher();
-    const mockDispatch = vi.mocked(dispatcher.dispatchEvent);
 
     const processor = getForwardingEventProcessor(dispatcher);
     
@@ -56,7 +55,6 @@ describe('ForwardingEventProcessor', () => {
 
   it('should emit dispatch event when event is dispatched', async() => {
     const dispatcher = getMockEventDispatcher();
-    const mockDispatch = vi.mocked(dispatcher.dispatchEvent);
 
     const processor = getForwardingEventProcessor(dispatcher);
     
@@ -76,7 +74,6 @@ describe('ForwardingEventProcessor', () => {
 
   it('should remove dispatch listener when the function returned from onDispatch is called', async() => {
     const dispatcher = getMockEventDispatcher();
-    const mockDispatch = vi.mocked(dispatcher.dispatchEvent);
 
     const processor = getForwardingEventProcessor(dispatcher);
     
diff --git a/lib/index.node.ts b/lib/index.node.ts
@@ -27,7 +27,6 @@ import { NodeOdpManager } from './plugins/odp_manager/index.node';
 import * as commonExports from './common_exports';
 import { createPollingProjectConfigManager } from './project_config/config_manager_factory.node';
 import { createForwardingEventProcessor, createBatchEventProcessor } from './event_processor/event_processor_factory.node';
-import { create } from 'domain';
 
 const logger = getLogger();
 setLogLevel(LogLevel.ERROR);
diff --git a/lib/optimizely/index.ts b/lib/optimizely/index.ts
@@ -20,15 +20,13 @@ import { NotificationCenter } from '../core/notification_center';
 import { EventProcessor } from '../event_processor/eventProcessor';
 
 import { IOdpManager } from '../core/odp/odp_manager';
-import { OdpConfig } from '../core/odp/odp_config';
 import { OdpEvent } from '../core/odp/odp_event';
 import { OptimizelySegmentOption } from '../core/odp/optimizely_segment_option';
 
 import {
   UserAttributes,
   EventTags,
   OptimizelyConfig,
-  OnReadyResult,
   UserProfileService,
   Variation,
   FeatureFlag,
diff --git a/lib/tests/mock/create_event.ts b/lib/tests/mock/create_event.ts
@@ -1,5 +1,18 @@
-import { EventV1 } from "../../event_processor";
-import { Event } from "../../shared_types";
+/**
+ * Copyright 2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
 export function createImpressionEvent(id = 'uuid'): any {
   return {
diff --git a/lib/tests/mock/mock_cache.ts b/lib/tests/mock/mock_cache.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { SyncCache, AsyncCache } from "../../utils/cache/cache";
 import { Maybe } from "../../utils/type";
 
diff --git a/lib/utils/cache/async_storage_cache.react_native.spec.ts b/lib/utils/cache/async_storage_cache.react_native.spec.ts
@@ -1,4 +1,19 @@
 
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
 vi.mock('@react-native-async-storage/async-storage', () => {
   const MockAsyncStorage = {
diff --git a/lib/utils/cache/async_storage_cache.react_native.ts b/lib/utils/cache/async_storage_cache.react_native.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { Maybe } from "../type";
 import { AsyncCache } from "./cache";
 import AsyncStorage from '@react-native-async-storage/async-storage';
diff --git a/lib/utils/cache/cache.spec.ts b/lib/utils/cache/cache.spec.ts
@@ -1,4 +1,20 @@
-import { describe, it, expect, beforeEach } from 'vitest';
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { describe, it, expect } from 'vitest';
 import { SyncPrefixCache, AsyncPrefixCache } from './cache';
 import { getMockSyncCache, getMockAsyncCache } from '../../tests/mock/mock_cache';
 
diff --git a/lib/utils/cache/cache.ts b/lib/utils/cache/cache.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { Transformer } from '../../utils/type';
 import { Maybe } from '../../utils/type';
 
diff --git a/lib/utils/cache/local_storage_cache.browser.spec.ts b/lib/utils/cache/local_storage_cache.browser.spec.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { describe, it, expect, beforeEach } from 'vitest';
 import { LocalStorageCache } from './local_storage_cache.browser';
 
diff --git a/lib/utils/cache/local_storage_cache.browser.ts b/lib/utils/cache/local_storage_cache.browser.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 import { Maybe } from "../type";
 import { SyncCache } from "./cache";
 
diff --git a/lib/utils/executor/backoff_retry_runner.spec.ts b/lib/utils/executor/backoff_retry_runner.spec.ts
@@ -81,9 +81,7 @@ describe('runWithRetry', () => {
   });
 
   it('should use the backoff controller to delay retries', async () => {
-    let count = 0;
     const task = vi.fn().mockImplementation(async () => {
-      count++;
       throw new Error('error');
     });
 
diff --git a/lib/utils/executor/backoff_retry_runner.ts b/lib/utils/executor/backoff_retry_runner.ts
@@ -1,7 +1,6 @@
 import { resolvablePromise, ResolvablePromise } from "../promise/resolvablePromise";
 import { BackoffController } from "../repeater/repeater";
-import { AsyncFn, AsyncProducer, Fn } from "../type";
-import { scheduleMicrotask } from "../microtask";
+import { AsyncProducer, Fn } from "../type";
 
 export type RunResult<T> = {
   result: Promise<T>;
diff --git a/lib/utils/id_generator/index.ts b/lib/utils/id_generator/index.ts
@@ -1,3 +1,19 @@
+/**
+ * Copyright 2022-2024, Optimizely
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 const idSuffixBase = 10_000;
 
 export class IdGenerator {
