decision: part 2

Author: raju-opti

lib/core/decision_service/index.tests.js

@@ -49,6 +49,7 @@ import {
   EXPERIMENT_NOT_RUNNING,
   RETURNING_STORED_VARIATION
 } from '../../log_messages';
+import { mock } from 'node:test';
 
 var testData = getTestProjectConfig();
 var testDataWithFeatures = getTestProjectConfigWithFeatures();
@@ -1255,7 +1256,11 @@ describe('lib/core/decision_service', function() {
       beforeEach(function() {
         configObj = projectConfig.createProjectConfig(cloneDeep(testDataWithFeatures));
         sandbox = sinon.sandbox.create();
-        sandbox.stub(mockLogger, 'log');
+        sandbox.stub(mockLogger, 'debug');
+        sandbox.stub(mockLogger, 'info');
+        sandbox.stub(mockLogger, 'warn');
+        sandbox.stub(mockLogger, 'error');
+
         decisionServiceInstance = createDecisionService({
           logger: mockLogger,
         });
@@ -2297,10 +2302,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.FEATURE_TEST,
           };
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 2400 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user142222'
@@ -2327,10 +2329,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.FEATURE_TEST,
           };
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 4000 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user142223'
@@ -2357,10 +2356,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.FEATURE_TEST,
           };
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 6500 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user142224'
@@ -2405,10 +2401,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.ROLLOUT,
           }
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 8000 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1594066'
@@ -2453,10 +2446,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.ROLLOUT,
           }
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[18]),
-            'BUCKETER: Assigned bucket 2400 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1594066'
@@ -2493,10 +2483,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.FEATURE_TEST,
           };
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 2400 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1111134'
@@ -2524,10 +2511,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.FEATURE_TEST,
           };
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 4000 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1111135'
@@ -2555,10 +2539,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.FEATURE_TEST,
           };
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 6500 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1111136'
@@ -2603,10 +2584,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.ROLLOUT,
           }
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[3]),
-            'BUCKETER: Assigned bucket 8000 to user with bucketing ID user1.'
-          );
+          
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1594066'
@@ -2651,10 +2629,7 @@ describe('lib/core/decision_service', function() {
             decisionSource: DECISION_SOURCES.ROLLOUT,
           }
           assert.deepEqual(decision, expectedDecision);
-          assert.strictEqual(
-            buildLogMessageFromArgs(mockLogger.log.args[18]),
-            'BUCKETER: Assigned bucket 4000 to user with bucketing ID user1.'
-          );
+
           sinon.assert.calledWithExactly(
             generateBucketValueStub,
             'user1594066'