[FSSDK-11100] test fix

Author: junaed-optimizely

lib/core/audience_evaluator/index.spec.ts

@@ -209,7 +209,6 @@ describe('lib/core/audience_evaluator', () => {
         describe('integration with dependencies', () => {
           beforeEach(() => {
             vi.clearAllMocks();
-            vi.spyOn(conditionTreeEvaluator, 'evaluate').mockImplementation(() => true);
           });
 
           afterEach(() => {
@@ -306,7 +305,7 @@ describe('lib/core/audience_evaluator', () => {
             expect(mockCustomAttributeConditionEvaluator).toHaveBeenCalledTimes(1);
             expect(mockCustomAttributeConditionEvaluator).toHaveBeenCalledWith(iphoneUserAudience.conditions[1], user);
             expect(result).toBe(false);
-            expect(2).toStrictEqual(mockLogger.debug.caller);
+            expect(mockLogger.debug).toHaveBeenCalledTimes(2);
 
             expect(mockLogger.debug).toHaveBeenCalledWith(
               EVALUATING_AUDIENCE,
@@ -333,7 +332,7 @@ describe('lib/core/audience_evaluator', () => {
             expect(mockCustomAttributeConditionEvaluator).toHaveBeenCalledTimes(1);
             expect(mockCustomAttributeConditionEvaluator).toHaveBeenCalledWith(iphoneUserAudience.conditions[1], user);
             expect(result).toBe(true);
-            expect(2).toStrictEqual(mockLogger.debug.call.length);
+            expect(mockLogger.debug).toHaveBeenCalledTimes(2)
             expect(mockLogger.debug).toHaveBeenCalledWith(
               EVALUATING_AUDIENCE,
               '1',
@@ -359,7 +358,7 @@ describe('lib/core/audience_evaluator', () => {
             expect(mockCustomAttributeConditionEvaluator).toHaveBeenCalledTimes(1);
             expect(mockCustomAttributeConditionEvaluator).toHaveBeenCalledWith(iphoneUserAudience.conditions[1], user);
             expect(result).toBe(false);
-            expect(2).toStrictEqual(mockLogger.debug.call.length);
+            expect(mockLogger.debug).toHaveBeenCalledTimes(2)
             expect(mockLogger.debug).toHaveBeenCalledWith(
               EVALUATING_AUDIENCE,
               '1',

lib/core/audience_evaluator/odp_segment_condition_evaluator/index.spec.ts

@@ -13,12 +13,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { beforeEach, afterEach, describe, it, vi, expect } from 'vitest';
-
+import { afterEach, describe, it, vi, expect } from 'vitest';
 import * as odpSegmentEvalutor from '.';
 import { UNKNOWN_MATCH_TYPE } from '../../../message/error_message';
 import { IOptimizelyUserContext } from '../../../optimizely_user_context';
 import { OptimizelyDecideOption, OptimizelyDecision } from '../../../shared_types';
+import { getMockLogger } from '../../../tests/mock/mock_logger';
 
 const odpSegment1Condition = {
   "value": "odp-segment-1",
@@ -46,23 +46,10 @@ const getMockUserContext = (attributes?: unknown, segments?: string[]): IOptimiz
 }) as IOptimizelyUserContext;
 
 
-const createLogger = () => ({
-  debug: () => {},
-  info: () => {},
-  warn: () => {},
-  error: () => {},
-  child: () => createLogger(),
-})
-
 describe('lib/core/audience_evaluator/odp_segment_condition_evaluator', function() {
-  const mockLogger = createLogger();
+  const mockLogger = getMockLogger();
   const { evaluate } = odpSegmentEvalutor.getEvaluator(mockLogger);
 
-  beforeEach(function() {
-    vi.fn(mockLogger.warn);
-    vi.fn(mockLogger.error);
-  });
-
   afterEach(function() {
     vi.restoreAllMocks();
   });
@@ -82,7 +69,6 @@ describe('lib/core/audience_evaluator/odp_segment_condition_evaluator', function
     };
     expect(evaluate(invalidOdpMatchCondition, getMockUserContext({}, ['odp-segment-1']))).toBeNull();
     expect(mockLogger.warn).toHaveBeenCalledTimes(1);
-    expect(mockLogger.warn.arguments[0][0]).toStrictEqual(UNKNOWN_MATCH_TYPE);
-    expect(mockLogger.warn.arguments[0][1]).toStrictEqual(JSON.stringify(invalidOdpMatchCondition));
+    expect(mockLogger.warn).toHaveBeenCalledWith(UNKNOWN_MATCH_TYPE, JSON.stringify(invalidOdpMatchCondition));
   });
 });