Skip to content

Commit f4d5ed5

Browse files
feat: use enableVuid option in BrowserOdpManager
1 parent e1f2ee1 commit f4d5ed5

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed

lib/plugins/odp_manager/index.browser.ts

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,12 @@ import {
2121
ODP_USER_KEY,
2222
REQUEST_TIMEOUT_ODP_SEGMENTS_MS,
2323
REQUEST_TIMEOUT_ODP_EVENTS_MS,
24-
LOG_MESSAGES,
2524
} from '../../utils/enums';
26-
import { getLogger, LogHandler, LogLevel } from '../../modules/logging';
25+
import { getLogger, LogHandler } from '../../modules/logging';
2726

2827
import { BrowserRequestHandler } from './../../utils/http_request_handler/browser_request_handler';
2928

3029
import BrowserAsyncStorageCache from '../key_value_cache/browserAsyncStorageCache';
31-
import PersistentKeyValueCache from '../key_value_cache/persistentKeyValueCache';
3230
import { BrowserLRUCache } from '../../utils/lru_cache';
3331

3432
import { VuidManager } from './../vuid_manager/index';
@@ -53,8 +51,8 @@ interface BrowserOdpManagerConfig {
5351
// Client-side Browser Plugin for ODP Manager
5452
export class BrowserOdpManager extends OdpManager {
5553
static cache = new BrowserAsyncStorageCache();
56-
vuidManager?: VuidManager;
5754
vuid?: string;
55+
private static shouldUseVuid = false;
5856

5957
constructor(options: {
6058
odpIntegrationConfig?: OdpIntegrationConfig;
@@ -73,13 +71,12 @@ export class BrowserOdpManager extends OdpManager {
7371
clientEngine = clientEngine || JAVASCRIPT_CLIENT_ENGINE;
7472
clientVersion = clientVersion || CLIENT_VERSION;
7573

76-
let odpConfig : OdpConfig | undefined = undefined;
74+
let odpConfig: OdpConfig | undefined = undefined;
7775
if (odpIntegrationConfig?.integrated) {
7876
odpConfig = odpIntegrationConfig.odpConfig;
7977
}
8078

8179
let customSegmentRequestHandler;
82-
8380
if (odpOptions?.segmentsRequestHandler) {
8481
customSegmentRequestHandler = odpOptions.segmentsRequestHandler;
8582
} else {
@@ -90,24 +87,22 @@ export class BrowserOdpManager extends OdpManager {
9087
}
9188

9289
let segmentManager: IOdpSegmentManager;
93-
9490
if (odpOptions?.segmentManager) {
9591
segmentManager = odpOptions.segmentManager;
9692
} else {
9793
segmentManager = new OdpSegmentManager(
9894
odpOptions?.segmentsCache ||
99-
new BrowserLRUCache<string, string[]>({
100-
maxSize: odpOptions?.segmentsCacheSize,
101-
timeout: odpOptions?.segmentsCacheTimeout,
102-
}),
95+
new BrowserLRUCache<string, string[]>({
96+
maxSize: odpOptions?.segmentsCacheSize,
97+
timeout: odpOptions?.segmentsCacheTimeout,
98+
}),
10399
new OdpSegmentApiManager(customSegmentRequestHandler, logger),
104100
logger,
105101
odpConfig
106102
);
107103
}
108104

109105
let customEventRequestHandler;
110-
111106
if (odpOptions?.eventRequestHandler) {
112107
customEventRequestHandler = odpOptions.eventRequestHandler;
113108
} else {
@@ -118,7 +113,6 @@ export class BrowserOdpManager extends OdpManager {
118113
}
119114

120115
let eventManager: IOdpEventManager;
121-
122116
if (odpOptions?.eventManager) {
123117
eventManager = odpOptions.eventManager;
124118
} else {
@@ -135,6 +129,8 @@ export class BrowserOdpManager extends OdpManager {
135129
});
136130
}
137131

132+
this.shouldUseVuid = odpOptions?.enableVuid || false;
133+
138134
return new BrowserOdpManager({
139135
odpIntegrationConfig,
140136
segmentManager,
@@ -149,6 +145,13 @@ export class BrowserOdpManager extends OdpManager {
149145
*/
150146
protected async initializeVuid(): Promise<void> {
151147
const vuidManager = await VuidManager.instance(BrowserOdpManager.cache);
148+
149+
if (!this.isVuidEnabled()) {
150+
await vuidManager.remove(BrowserOdpManager.cache);
151+
// assign default empty string VUID from VuidManager instead of
152+
// early return here.
153+
}
154+
152155
this.vuid = vuidManager.vuid;
153156
}
154157

@@ -194,7 +197,7 @@ export class BrowserOdpManager extends OdpManager {
194197
}
195198

196199
isVuidEnabled(): boolean {
197-
return true;
200+
return BrowserOdpManager.shouldUseVuid;
198201
}
199202

200203
getVuid(): string | undefined {

0 commit comments

Comments
 (0)