Skip to content

[FSSDK-11035] add logger factory and tests #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 21, 2025
Merged

[FSSDK-11035] add logger factory and tests #985

merged 5 commits into from
Jan 21, 2025

Conversation

raju-opti
Copy link
Contributor

Summary

Test plan

  • added relevant tests

Issues

  • FSSDK-11035

@raju-opti raju-opti requested a review from a team as a code owner January 20, 2025 12:57
junaed-optimizely
junaed-optimizely approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except couple of NITS and copyright text issues.

@raju-opti raju-opti merged commit 36d7ef7 into master Jan 21, 2025
11 of 18 checks passed
@raju-opti raju-opti deleted the raju/logger-factory branch January 21, 2025 09:48
@coveralls
Copy link

Coverage Status

coverage: 81.835% (-0.1%) from 81.933%
when pulling 9f7ee4f on raju/logger-factory
into 02d7c77 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely