update: new class method to handle optimizely error decisions

Author: FarhanAnjum-opti

optimizely/decision/optimizely_decision.py

@@ -48,3 +48,25 @@ def as_json(self) -> dict[str, Any]:
             'user_context': self.user_context.as_json() if self.user_context else None,
             'reasons': self.reasons
         }
+
+    @classmethod
+    def new_error_decision(cls, key: str, user: OptimizelyUserContext, reasons: list[str]) -> OptimizelyDecision:
+        """Create a new OptimizelyDecision representing an error state.
+
+        Args:
+            key: The flag key
+            user: The user context
+            reasons: List of reasons explaining the error
+
+        Returns:
+            OptimizelyDecision with error state values
+        """
+        return cls(
+            variation_key=None,
+            enabled=False,
+            variables={},
+            rule_key=None,
+            flag_key=key,
+            user_context=user,
+            reasons=[reasons[-1]] if reasons else []
+        )

optimizely/decision_service.py

@@ -162,12 +162,9 @@ def _get_decision_for_cmab_experiment(
                 "reasons": [],
             }
         except Exception as e:
-            error_message = Errors.CMAB_FETCH_FAILED_DETAILED.format(
-                experiment.key,
-                str(e)
-            )
+            error_message = Errors.CMAB_FETCH_FAILED_DETAILED.format(experiment.key)
             if self.logger:
-                self.logger.error(error_message)
+                self.logger.error(f"{error_message} - {str(e)}")
             return {
                 "error": True,
                 "result": None,

optimizely/helpers/enums.py

@@ -129,7 +129,7 @@ class Errors:
     MISSING_SDK_KEY: Final = 'SDK key not provided/cannot be found in the datafile.'
     CMAB_FETCH_FAILED: Final = 'CMAB decision fetch failed with status: {}'
     INVALID_CMAB_FETCH_RESPONSE: Final = 'Invalid CMAB fetch response'
-    CMAB_FETCH_FAILED_DETAILED: Final = 'Failed to fetch CMAB decision for experiment key "{}" - {}'
+    CMAB_FETCH_FAILED_DETAILED: Final = 'Failed to fetch CMAB data for experiment {}'
 
 
 class ForcedDecisionLogs:

optimizely/optimizely.py

@@ -1380,10 +1380,15 @@ def _decide_for_keys(
         for i in range(0, len(flags_without_forced_decision)):
             decision = decision_list[i]['decision']
             reasons = decision_list[i]['reasons']
-            # Can catch errors now. Not used as decision logic implicitly handles error decision.
-            # Will be required for impression events
-            # error = decision_list[i]['error']
+            error = decision_list[i]['error']
             flag_key = flags_without_forced_decision[i].key
+            # store error decision against key and remove key from valid keys
+            if error:
+                optimizely_decision = OptimizelyDecision.new_error_decision(flags_without_forced_decision[i].key,
+                                                                            user_context, reasons)
+                decisions[flag_key] = optimizely_decision
+                if flag_key in valid_keys:
+                    valid_keys.remove(flag_key)
             flag_decisions[flag_key] = decision
             decision_reasons_dict[flag_key] += reasons