Skip to content

Commit c0869e8

Browse files
refactor: simplify remove method in LRUCache and update related tests
1 parent 2837df8 commit c0869e8

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

optimizely/odp/lru_cache.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,6 @@ def peek(self, key: K) -> Optional[V]:
9393

9494
def remove(self, key: K) -> None:
9595
"""Remove the element associated with the provided key from the cache."""
96-
if self.capacity <= 0:
97-
return
98-
9996
with self.lock:
10097
self.map.pop(key, None)
10198

tests/test_lru_cache.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ def test_remove_non_existent_key(self):
139139

140140
self.assertEqual(cache.lookup("1"), 100)
141141
self.assertEqual(cache.lookup("2"), 200)
142-
self.assertEqual(len(cache.map), 2)
143142

144143
def test_remove_existing_key(self):
145144
cache = LRUCache(3, 1000)
@@ -151,14 +150,12 @@ def test_remove_existing_key(self):
151150
self.assertEqual(cache.lookup("1"), 100)
152151
self.assertEqual(cache.lookup("2"), 200)
153152
self.assertEqual(cache.lookup("3"), 300)
154-
self.assertEqual(len(cache.map), 3)
155153

156154
cache.remove("2")
157155

158156
self.assertEqual(cache.lookup("1"), 100)
159157
self.assertIsNone(cache.lookup("2"))
160158
self.assertEqual(cache.lookup("3"), 300)
161-
self.assertEqual(len(cache.map), 2)
162159

163160
def test_remove_from_zero_sized_cache(self):
164161
cache = LRUCache(0, 1000)
@@ -180,7 +177,6 @@ def test_remove_and_add_back(self):
180177
self.assertEqual(cache.lookup("1"), 100)
181178
self.assertEqual(cache.lookup("2"), 201)
182179
self.assertEqual(cache.lookup("3"), 300)
183-
self.assertEqual(len(cache.map), 3)
184180

185181
def test_thread_safety(self):
186182
import threading

0 commit comments

Comments
 (0)