Skip to content

Commit d5ed569

Browse files
author
Paul V Craven
committed
Fix mypy error and linting error
1 parent 8624e1e commit d5ed569

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

optimizely/config_manager.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,9 @@ def fetch_datafile(self) -> None:
404404

405405
session.mount('http://', adapter)
406406
session.mount("https://", adapter)
407-
response = session.get(self.datafile_url, headers=request_headers, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
407+
response = session.get(self.datafile_url,
408+
headers=request_headers,
409+
timeout=enums.ConfigManager.REQUEST_TIMEOUT)
408410
except requests_exceptions.RequestException as err:
409411
self.logger.error(f'Fetching datafile from {self.datafile_url} failed. Error: {err}')
410412
return
@@ -495,7 +497,9 @@ def fetch_datafile(self) -> None:
495497

496498
session.mount('http://', adapter)
497499
session.mount("https://", adapter)
498-
response = session.get(self.datafile_url, headers=request_headers, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
500+
response = session.get(self.datafile_url,
501+
headers=request_headers,
502+
timeout=enums.ConfigManager.REQUEST_TIMEOUT)
499503
except requests_exceptions.RequestException as err:
500504
self.logger.error(f'Fetching datafile from {self.datafile_url} failed. Error: {err}')
501505
return

optimizely/helpers/validator.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,9 @@ def is_finite_number(value: Any) -> bool:
276276
if math.isnan(value) or math.isinf(value):
277277
return False
278278

279-
if abs(value) > (2 ** 53):
280-
return False
279+
if isinstance(value, int):
280+
if abs(value) > (2 ** 53):
281+
return False
281282

282283
return True
283284

0 commit comments

Comments
 (0)