Skip to content

Commit 1aed587

Browse files
update: modify rubocop installation in CI workflow and remove it from development dependencies
1 parent edb02c6 commit 1aed587

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

.github/workflows/ruby.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,16 @@ jobs:
3333
with:
3434
ruby-version: ${{ matrix.ruby }}
3535
bundler-cache: true
36-
- name: Install rubocop 1.78.0 for Ruby 3.0.0
37-
if: matrix.ruby == '3.0.0'
36+
- name: Install rubocop conditionally based on Ruby version
3837
run: |
39-
echo "Installing rubocop 1.78.0 for Ruby 3.0.0"
40-
gem install rubocop -v 1.78.0
38+
echo "Ruby version: ${{ matrix.ruby }}"
39+
if [[ "${{ matrix.ruby }}" == "3.0.0" ]]; then
40+
echo "Installing rubocop 1.78.0 for Ruby 3.0.0"
41+
gem install rubocop -v 1.78.0
42+
else
43+
echo "Installing latest rubocop"
44+
gem install rubocop
45+
fi
4146
- name: Run linting
4247
run: |
4348
bundle exec rubocop

optimizely-sdk.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ Gem::Specification.new do |spec|
2525
spec.add_development_dependency 'coveralls_reborn'
2626
spec.add_development_dependency 'rake'
2727
spec.add_development_dependency 'rspec'
28-
spec.add_development_dependency 'rubocop'
2928
spec.add_development_dependency 'webmock'
3029

3130
spec.add_runtime_dependency 'json-schema', '>= 2.6'

0 commit comments

Comments
 (0)