update: Refactor attribute filtering logic and improve test attribute structure

Author: FarhanAnjum-opti

lib/optimizely/cmab/cmab_service.rb

@@ -119,7 +119,10 @@ def filter_attributes(project_config, user_context, rule_id)
       cmab_attribute_ids = experiment['cmab']['attributeIds']
       cmab_attribute_ids.each do |attribute_id|
         attribute = project_config.attribute_id_map[attribute_id]
-        filtered_user_attributes[attribute.key] = user_attributes[attribute.key] if attribute && user_attributes.key?(attribute.key)
+        next unless attribute
+
+        attribute_key = attribute['key']
+        filtered_user_attributes[attribute_key] = user_attributes[attribute_key] if user_attributes.key?(attribute_key)
       end
 
       filtered_user_attributes

spec/cmab/cmab_service_spec.rb

@@ -19,8 +19,8 @@
   let(:user_attributes) { {'age' => 25, 'location' => 'USA'} }
 
   let(:mock_experiment) { {'cmab' => {'attributeIds' => %w[66 77]}} }
-  let(:mock_attr1) { double('attribute', key: 'age') }
-  let(:mock_attr2) { double('attribute', key: 'location') }
+  let(:mock_attr1) { {'key' => 'age'} }
+  let(:mock_attr2) { {'key' => 'location'} }
 
   before do
     allow(mock_user_context).to receive(:user_id).and_return(user_id)