Fix errors

Author: esrakartalOpt

lib/optimizely/config/datafile_project_config.rb

@@ -453,7 +453,7 @@ def get_attribute_by_key(attribute_key)
       # Returns:
       #   Attribute corresponding to the provided attribute key.
       attribute = @attribute_key_map[attribute_key]
-      if attribute_key in @attribute_key_map
+      if @attribute_key_map.key?(attribute_key)
         return attribute
       end
 
@@ -472,7 +472,7 @@ def get_attribute_key_by_id(attribute_id)
       # Returns:
       #   Attribute key corresponding to the provided attribute ID.
       attribute = @attribute_id_to_key_map[attribute_id]
-      if attribute_id in @attribute_id_to_key_map
+      if @attribute_id_to_key_map.key?(attribute_id)
         return attribute
       end
 

lib/optimizely/helpers/constants.rb

@@ -203,7 +203,7 @@ module Constants
                   'type' => 'object'
                 },
                 'cmab' => {
-                  'type' => 'object',
+                  'type' => 'object'
                 }
               },
               'required' => %w[
@@ -313,10 +313,10 @@ module Constants
               'type' => 'object',
               'properties' => {
                 'attributeIds' => {
-                  'type' => 'array',
+                  'type' => 'array'
                 },
                 'trafficAllocation' => {
-                  'type' => 'integer',
+                  'type' => 'integer'
                 }
               }
             }

spec/config/datafile_project_config_spec.rb

@@ -1080,15 +1080,15 @@
 
   describe 'test_cmab_field_population' do
     config_dict = Marshal.load(Marshal.dump(OptimizelySpec::VALID_CONFIG_BODY))
-    config_dict['experiments'][0]['cmab'] = { 'attributeIds' => ['808797688', '808797689'], 'trafficAllocation' => 4000 }
+    config_dict['experiments'][0]['cmab'] = {'attributeIds' => %w[808797688 808797689], 'trafficAllocation' => 4000}
     config_dict['experiments'][0]['trafficAllocation'] = []
 
     config_json = JSON.dump(config_dict)
     project_config = Optimizely::DatafileProjectConfig.new(config_json, logger, error_handler)
 
     it 'Should return CMAB details' do
       experiment = project_config.get_experiment_from_key('test_experiment')
-      expect(experiment['cmab']).to eq({'attributeIds' => ['808797688', '808797689'], 'trafficAllocation' => 4000})
+      expect(experiment['cmab']).to eq({'attributeIds' => %w[808797688 808797689], 'trafficAllocation' => 4000})
 
       experiment2 = project_config.get_experiment_from_key('test_experiment_2')
       expect(experiment2['cmab']).to eq(nil)