Fix logger issue

Author: esrakartalOpt

spec/cmab_client_spec.rb

@@ -20,9 +20,9 @@
 
 describe Optimizely::DefaultCmabClient do
   let(:mock_http_client) { double('http_client') }
-  let(:mock_logger) { double('logger') }
+  let(:spy_logger) { spy('logger') }
   let(:retry_config) { Optimizely::CmabRetryConfig.new(max_retries: 3, retry_delay: 0.01, max_backoff: 1, backoff_multiplier: 2) }
-  let(:client) { described_class.new(http_client: mock_http_client, logger: mock_logger, retry_config: nil) }
+  let(:client) { described_class.new(http_client: mock_http_client, logger: spy_logger, retry_config: nil) }
   let(:rule_id) { 'test_rule' }
   let(:user_id) { 'user123' }
   let(:attributes) { {'attr1': 'value1', 'attr2': 'value2'} }
@@ -60,12 +60,12 @@
 
   it 'should return HTTP exception without retrying' do
     allow(mock_http_client).to receive(:post).and_raise(StandardError.new('Connection error'))
-    allow(mock_logger).to receive(:error)
+
     expect do
       client.fetch_decision(rule_id, user_id, attributes, cmab_uuid)
     end.to raise_error(Optimizely::CmabFetchError, /Connection error/)
     expect(mock_http_client).to have_received(:post).once
-    expect(mock_logger).to have_received(:error).with(a_string_including('Connection error'))
+    expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Connection error'))
   end
 
   it 'should not return 200 status without retrying' do
@@ -84,7 +84,7 @@
         timeout: 10
       )
     )
-    expect(mock_logger).to have_received(:error).with(a_string_including('500'))
+    expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('500'))
   end
 
   it 'should return invalid json without retrying' do
@@ -104,7 +104,7 @@
         timeout: 10
       )
     )
-    expect(mock_logger).to have_received(:error).with(a_string_including('Invalid CMAB fetch response'))
+    expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Invalid CMAB fetch response'))
   end
 
   it 'should return invalid response structure without retrying' do
@@ -123,13 +123,13 @@
         timeout: 10
       )
     )
-    expect(mock_logger).to have_received(:error).with(a_string_including('Invalid CMAB fetch response'))
+    expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Invalid CMAB fetch response'))
   end
 
   it 'should return the variation id on first try with retry config but no retry needed' do
     client_with_retry = described_class.new(
       http_client: mock_http_client,
-      logger: mock_logger,
+      logger: spy_logger,
       retry_config: retry_config
     )
 
@@ -155,7 +155,7 @@
   it 'should return the variation id on third try with retry config' do
     client_with_retry = described_class.new(
       http_client: mock_http_client,
-      logger: mock_logger,
+      logger: spy_logger,
       retry_config: retry_config
     )
 
@@ -167,7 +167,6 @@
     call_sequence = [failure_response, failure_response, success_response]
     allow(mock_http_client).to receive(:post) { call_sequence.shift }
 
-    allow(mock_logger).to receive(:info)
     allow_any_instance_of(Object).to receive(:sleep)
 
     result = client_with_retry.fetch_decision(rule_id, user_id, attributes, cmab_uuid)
@@ -186,8 +185,8 @@
     )
 
     # Verify retry logging
-    expect(mock_logger).to have_received(:info).with('Retrying CMAB request (attempt 1) after 0.01 seconds...')
-    expect(mock_logger).to have_received(:info).with('Retrying CMAB request (attempt 2) after 0.02 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 1) after 0.01 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 2) after 0.02 seconds...')
 
     # Verify sleep was called with correct backoff times
     expect_any_instance_of(Object).to have_received(:sleep).with(0.01)
@@ -197,7 +196,7 @@
   it 'should exhausts all retry attempts' do
     client_with_retry = described_class.new(
       http_client: mock_http_client,
-      logger: mock_logger,
+      logger: spy_logger,
       retry_config: retry_config
     )
 
@@ -206,8 +205,6 @@
 
     # All attempts fail
     allow(mock_http_client).to receive(:post).and_return(failure_response)
-    allow(mock_logger).to receive(:info)
-    allow(mock_logger).to receive(:error)
     allow_any_instance_of(Object).to receive(:sleep)
 
     expect do
@@ -218,16 +215,16 @@
     expect(mock_http_client).to have_received(:post).exactly(4).times
 
     # Verify retry logging
-    expect(mock_logger).to have_received(:info).with('Retrying CMAB request (attempt 1) after 0.01 seconds...')
-    expect(mock_logger).to have_received(:info).with('Retrying CMAB request (attempt 2) after 0.02 seconds...')
-    expect(mock_logger).to have_received(:info).with('Retrying CMAB request (attempt 3) after 0.08 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 1) after 0.01 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 2) after 0.02 seconds...')
+    expect(spy_logger).to have_received(:log).with(Logger::INFO, 'Retrying CMAB request (attempt 3) after 0.08 seconds...')
 
     # Verify sleep was called for each retry
     expect_any_instance_of(Object).to have_received(:sleep).with(0.01)
     expect_any_instance_of(Object).to have_received(:sleep).with(0.02)
     expect_any_instance_of(Object).to have_received(:sleep).with(0.08)
 
     # Verify final error logging
-    expect(mock_logger).to have_received(:error).with(a_string_including('Max retries exceeded for CMAB request'))
+    expect(spy_logger).to have_received(:log).with(Logger::ERROR, a_string_including('Max retries exceeded for CMAB request'))
   end
 end