Skip to content

Commit 45140d9

Browse files
Add comment about cmab error handling
1 parent 2cd2981 commit 45140d9

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

Sources/Implementation/DefaultDecisionService.swift

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -453,8 +453,13 @@ class DefaultDecisionService: OPTDecisionService {
453453
options: options)
454454
reasons.merge(decisionResponse.reasons)
455455
if let result = decisionResponse.result {
456-
if result.cmabError || result.variation != nil {
457-
let featureDecision = FeatureDecision(experiment: experiment, variation: result.variation, source: Constants.DecisionSource.featureTest.rawValue, cmabUUID: result.cmabUUID)
456+
if result.cmabError {
457+
// For CMAB - we're supposed to get decision from the server.
458+
// If failed, return decision with nil variation, so the client can take care of them.
459+
let featureDecision = FeatureDecision(experiment: experiment, variation: nil, source: Constants.DecisionSource.featureTest.rawValue)
460+
return DecisionResponse(result: featureDecision, reasons: reasons)
461+
} else if let variation = result.variation {
462+
let featureDecision = FeatureDecision(experiment: experiment, variation: variation, source: Constants.DecisionSource.featureTest.rawValue)
458463
return DecisionResponse(result: featureDecision, reasons: reasons)
459464
}
460465
}

0 commit comments

Comments
 (0)