Add test for impression event

Author: muzahidul-opti

Tests/OptimizelyTests-APIs/OptimizelyClientTests_Others.swift

@@ -289,7 +289,7 @@ class OptimizelyClientTests_Others: XCTestCase {
         // set invalid (infinity) to attribute values, which will cause JSONEncoder.encode exception
         let attributes = ["testvar": Double.infinity]
 
-        optimizely.sendImpressionEvent(experiment: experiment, variation: variation, userId: kUserId, attributes: attributes, flagKey: "", ruleType: Constants.DecisionSource.rollout.rawValue, enabled: true)
+        optimizely.sendImpressionEvent(experiment: experiment, variation: variation, userId: kUserId, attributes: attributes, flagKey: "", ruleType: Constants.DecisionSource.rollout.rawValue, enabled: true, cmabUUID: nil)
         XCTAssert(eventDispatcher.events.count == 0)
     }
 
@@ -321,7 +321,7 @@ class OptimizelyClientTests_Others: XCTestCase {
         // force condition for sdk-not-ready
         optimizely.config = nil
 
-        optimizely.sendImpressionEvent(experiment: experiment, variation: variation, userId: kUserId, flagKey: experiment.key, ruleType: Constants.DecisionSource.rollout.rawValue, enabled: true)
+        optimizely.sendImpressionEvent(experiment: experiment, variation: variation, userId: kUserId, flagKey: experiment.key, ruleType: Constants.DecisionSource.rollout.rawValue, enabled: true, cmabUUID: nil)
         XCTAssert(eventDispatcher.events.isEmpty, "event should not be sent out sdk is not configured properly")
 
         optimizely.sendConversionEvent(eventKey: kEventKey, userId: kUserId)

Tests/OptimizelyTests-Common/BatchEventBuilderTests_Events.swift

@@ -111,6 +111,7 @@ class BatchEventBuilderTests_Events: XCTestCase {
         XCTAssertEqual(metaData["rule_key"] as! String, "ab_running_exp_audience_combo_exact_foo_or_true__and__42_or_4_2")
         XCTAssertEqual(metaData["flag_key"] as! String, "")
         XCTAssertEqual(metaData["variation_key"] as! String, "all_traffic_variation")
+        XCTAssertNil(metaData["cmab_uuid"])
         XCTAssertTrue(metaData["enabled"] as! Bool)
 
         let de = (snapshot["events"]  as! Array<Dictionary<String, Any>>)[0]
@@ -212,7 +213,7 @@ class BatchEventBuilderTests_Events: XCTestCase {
         let experiment = optimizely.config?.getExperiment(id: "10390977714")
 
         optimizely.config?.project.sendFlagDecisions = true
-        let event = BatchEventBuilder.createImpressionEvent(config: optimizely.config!, experiment: experiment!, variation: nil, userId: userId, attributes: attributes, flagKey: experiment!.key, ruleType: Constants.DecisionSource.featureTest.rawValue, enabled: false)
+        let event = BatchEventBuilder.createImpressionEvent(config: optimizely.config!, experiment: experiment!, variation: nil, userId: userId, attributes: attributes, flagKey: experiment!.key, ruleType: Constants.DecisionSource.featureTest.rawValue, enabled: false, cmabUUID: "cmab_uuid_124")
         XCTAssertNotNil(event)
 
         let visitor = (getEventJSON(data: event!)!["visitors"] as! Array<Dictionary<String, Any>>)[0]
@@ -224,14 +225,15 @@ class BatchEventBuilderTests_Events: XCTestCase {
         XCTAssertEqual(metaData["rule_key"] as! String, "ab_running_exp_audience_combo_exact_foo_or_true__and__42_or_4_2")
         XCTAssertEqual(metaData["flag_key"] as! String, "ab_running_exp_audience_combo_exact_foo_or_true__and__42_or_4_2")
         XCTAssertEqual(metaData["variation_key"] as! String, "")
+        XCTAssertEqual(metaData["cmab_uuid"] as! String, "cmab_uuid_124")
         XCTAssertFalse(metaData["enabled"] as! Bool)
         optimizely.config?.project.sendFlagDecisions = nil
     }
 
     func testCreateImpressionEventWithoutExperimentAndVariation() {
 
         optimizely.config?.project.sendFlagDecisions = true
-        let event = BatchEventBuilder.createImpressionEvent(config: optimizely.config!, experiment: nil, variation: nil, userId: userId, attributes: [String: Any](), flagKey: "feature_1", ruleType: Constants.DecisionSource.rollout.rawValue, enabled: true)
+        let event = BatchEventBuilder.createImpressionEvent(config: optimizely.config!, experiment: nil, variation: nil, userId: userId, attributes: [String: Any](), flagKey: "feature_1", ruleType: Constants.DecisionSource.rollout.rawValue, enabled: true, cmabUUID: nil)
         XCTAssertNotNil(event)
 
         let visitor = (getEventJSON(data: event!)!["visitors"] as! Array<Dictionary<String, Any>>)[0]
@@ -243,6 +245,7 @@ class BatchEventBuilderTests_Events: XCTestCase {
         XCTAssertEqual(metaData["rule_key"] as! String, "")
         XCTAssertEqual(metaData["flag_key"] as! String, "feature_1")
         XCTAssertEqual(metaData["variation_key"] as! String, "")
+        XCTAssertEqual(metaData["cmab_uuid"] as? String, nil)
         XCTAssertTrue(metaData["enabled"] as! Bool)
         optimizely.config?.project.sendFlagDecisions = nil
     }

Tests/OptimizelyTests-Common/OptimizelyUserContextTests_Decide_CMAB.swift

@@ -72,7 +72,33 @@ class OptimizelyUserContextTests_Decide_CMAB: XCTestCase {
             XCTAssertTrue(self.mockCmabService.decisionCalled, "CMAB decision service was not called")
             XCTAssertEqual(self.mockCmabService.lastRuleId, "10390977673", "Expected CMAB rule id '10390977673' but got \(String(describing: self.mockCmabService.lastRuleId))")
 
-            expectation.fulfill()
+            // Give event dispatcher time to process
+            DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
+                // Verify impression event
+                self.optimizely.eventLock.sync {}
+                
+                guard let event = self.getFirstEventJSON(client: self.optimizely) else {
+                    XCTFail("No impression event found")
+                    expectation.fulfill()
+                    return
+                }
+                
+                let visitor = (event["visitors"] as! Array<Dictionary<String, Any>>)[0]
+                let snapshot = (visitor["snapshots"] as! Array<Dictionary<String, Any>>)[0]
+                let decision = (snapshot["decisions"] as! Array<Dictionary<String, Any>>)[0]
+                let metaData = decision["metadata"] as! Dictionary<String, Any>
+                
+                // Verify event metadata
+                XCTAssertEqual(metaData["rule_type"] as! String, Constants.DecisionSource.featureTest.rawValue)
+                XCTAssertEqual(metaData["rule_key"] as! String, "exp_with_audience")
+                XCTAssertEqual(metaData["flag_key"] as! String, "feature_1")
+                XCTAssertEqual(metaData["variation_key"] as! String, "a")
+                XCTAssertEqual(metaData["cmab_uuid"] as? String, "test-uuid")
+                XCTAssertTrue(metaData["enabled"] as! Bool)
+                
+                expectation.fulfill()
+            }
+            
         }
 
         wait(for: [expectation], timeout: 5) // Increased timeout for reliability
@@ -285,3 +311,31 @@ fileprivate class MockCmabService: DefaultCmabService {
         return .failure(CmabClientError.fetchFailed("No variation set"))
     }
 }
+
+extension OptimizelyUserContextTests_Decide_CMAB {
+    
+    func getFirstEvent(dispatcher: MockEventDispatcher) -> EventForDispatch? {
+        optimizely.eventLock.sync{}
+        return dispatcher.events.first
+    }
+    
+    func getFirstEventJSON(dispatcher: MockEventDispatcher) -> [String: Any]? {
+        guard let event = getFirstEvent(dispatcher: dispatcher) else { return nil }
+        
+        let json = try! JSONSerialization.jsonObject(with: event.body, options: .allowFragments) as! [String: Any]
+        return json
+    }
+    
+    func getFirstEventJSON(client: OptimizelyClient) -> [String: Any]? {
+        guard let event = getFirstEvent(dispatcher: client.eventDispatcher as! MockEventDispatcher) else { return nil }
+        
+        let json = try! JSONSerialization.jsonObject(with: event.body, options: .allowFragments) as! [String: Any]
+        return json
+    }
+    
+    func getEventJSON(data: Data) -> [String: Any]? {
+        let json = try! JSONSerialization.jsonObject(with: data, options: .allowFragments) as! [String: Any]
+        return json
+    }
+    
+}