fixed linters

Author: ab-cs13

internal/service/odb/network_peering_connection.go

@@ -77,20 +77,20 @@ func (r *resourceNetworkPeeringConnection) Schema(ctx context.Context, req resou
 				Description: "Required field. The unique identifier of the ODB peering connection. Changing this will force terraform to create new resource",
 			},
 
-			"display_name": schema.StringAttribute{
+			names.AttrDisplayName: schema.StringAttribute{
 				Description: "Display name of the odb network peering connection. Changing this will force terraform to create new resource",
 				Required:    true,
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.RequiresReplace(),
 				},
 			},
 
-			"status": schema.StringAttribute{
+			names.AttrStatus: schema.StringAttribute{
 				Description: "Status of the odb network peering connection.",
 				CustomType:  fwtypes.StringEnumType[odbtypes.ResourceStatus](),
 				Computed:    true,
 			},
-			"status_reason": schema.StringAttribute{
+			names.AttrStatusReason: schema.StringAttribute{
 				Description: "The reason for the current status of the ODB peering connection..",
 				Computed:    true,
 			},
@@ -108,7 +108,7 @@ func (r *resourceNetworkPeeringConnection) Schema(ctx context.Context, req resou
 				Description: "Type of the odb peering connection.",
 				Computed:    true,
 			},
-			"created_at": schema.StringAttribute{
+			names.AttrCreatedAt: schema.StringAttribute{
 				Description: "Created time of the odb network peering connection.",
 				Computed:    true,
 			},

internal/service/odb/network_peering_connection_data_source.go

@@ -40,16 +40,16 @@ func (d *dataSourceNetworkPeeringConnection) Schema(ctx context.Context, req dat
 				Description: "Network Peering Connection identifier.",
 				Required:    true,
 			},
-			"display_name": schema.StringAttribute{
+			names.AttrDisplayName: schema.StringAttribute{
 				Description: "Display name of the odb network peering connection.",
 				Computed:    true,
 			},
-			"status": schema.StringAttribute{
+			names.AttrStatus: schema.StringAttribute{
 				Description: "Status of the odb network peering connection.",
 				CustomType:  fwtypes.StringEnumType[odbtypes.ResourceStatus](),
 				Computed:    true,
 			},
-			"status_reason": schema.StringAttribute{
+			names.AttrStatusReason: schema.StringAttribute{
 				Description: "Status of the odb network peering connection.",
 				Computed:    true,
 			},
@@ -69,7 +69,7 @@ func (d *dataSourceNetworkPeeringConnection) Schema(ctx context.Context, req dat
 				Description: "Type of the odb peering connection.",
 				Computed:    true,
 			},
-			"created_at": schema.StringAttribute{
+			names.AttrCreatedAt: schema.StringAttribute{
 				Description: "Created time of the odb network peering connection.",
 				Computed:    true,
 			},

internal/service/odb/network_peering_connection_data_source_test.go

@@ -57,7 +57,7 @@ func TestAccODBNetworkPeeringConnectionDataSource_basic(t *testing.T) {
 			{
 				Config: odbPeeringDSTest.basicPeeringConfig(vpcName, odbNetDispName, odbNetPeeringDisplayName),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttrPair(networkPeeringResource, "id", networkPerringDataSource, "id"),
+					resource.TestCheckResourceAttrPair(networkPeeringResource, names.AttrID, networkPerringDataSource, names.AttrID),
 				),
 			},
 		},

internal/service/odb/network_peering_connection_test.go

@@ -61,7 +61,7 @@ func TestAccODBNetworkPeeringConnection_basic(t *testing.T) {
 				Config: odbNwkPeeringTestResource.basicConfig(vpcName, odbNetName, odbPeeringDisplayName),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckNetworkPeeringConnectionExists(ctx, resourceName, &odbPeeringResource),
-					resource.TestCheckResourceAttr(resourceName, "tags.%", "1"),
+					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
 					resource.TestCheckResourceAttr(resourceName, "tags.env", "dev"),
 				),
 			},
@@ -100,7 +100,7 @@ func TestAccODBNetworkPeeringConnection_tagging(t *testing.T) {
 				Config: odbNwkPeeringTestResource.basicConfig(vpcName, odbNetName, odbPeeringDisplayName),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckNetworkPeeringConnectionExists(ctx, resourceName, &odbPeeringResource),
-					resource.TestCheckResourceAttr(resourceName, "tags.%", "1"),
+					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
 					resource.TestCheckResourceAttr(resourceName, "tags.env", "dev"),
 				),
 			},
@@ -113,7 +113,7 @@ func TestAccODBNetworkPeeringConnection_tagging(t *testing.T) {
 				Config: odbNwkPeeringTestResource.basicConfigNoTag(vpcName, odbNetName, odbPeeringDisplayName),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					testAccCheckNetworkPeeringConnectionExists(ctx, resourceName, &odbPeeringResource),
-					resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
+					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "0"),
 				),
 			},
 			{