fixed linting issues of avmc

Author: ab-cs13

internal/service/odb/cloud_autonomous_vm_cluster.go

@@ -123,7 +123,7 @@ func (r *resourceCloudAutonomousVmCluster) Schema(ctx context.Context, req resou
 				Computed:    true,
 				Description: "The percentage of total CPU cores currently in use in the Autonomous VM cluster.",
 			},
-			"created_at": schema.StringAttribute{
+			names.AttrCreatedAt: schema.StringAttribute{
 				Computed:    true,
 				CustomType:  timetypes.RFC3339Type{},
 				Description: "The date and time when the Autonomous VM cluster was created.",
@@ -149,23 +149,23 @@ func (r *resourceCloudAutonomousVmCluster) Schema(ctx context.Context, req resou
 				},
 				Description: "The database servers in the Autonomous VM cluster. Changing this will force terraform to create new resource.",
 			},
-			"description": schema.StringAttribute{
+			names.AttrDescription: schema.StringAttribute{
 				Optional: true,
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.RequiresReplace(),
 					stringplanmodifier.UseStateForUnknown(),
 				},
 				Description: "The description of the Autonomous VM cluster.",
 			},
-			"display_name": schema.StringAttribute{
+			names.AttrDisplayName: schema.StringAttribute{
 				Required:   true,
 				Validators: stringLengthBetween1And255Validator,
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.RequiresReplace(),
 				},
 				Description: "The display name of the Autonomous VM cluster. Changing this will force terraform to create new resource.",
 			},
-			"domain": schema.StringAttribute{
+			names.AttrDomain: schema.StringAttribute{
 				Computed:    true,
 				Description: "The domain name of the Autonomous VM cluster.",
 			},
@@ -283,12 +283,12 @@ func (r *resourceCloudAutonomousVmCluster) Schema(ctx context.Context, req resou
 				Computed:    true,
 				Description: "The shape of the Exadata infrastructure for the Autonomous VM cluster.",
 			},
-			"status": schema.StringAttribute{
+			names.AttrStatus: schema.StringAttribute{
 				CustomType:  status,
 				Computed:    true,
 				Description: "The status of the Autonomous VM cluster. Possible values include CREATING, AVAILABLE , UPDATING , DELETING , DELETED , FAILED ",
 			},
-			"status_reason": schema.StringAttribute{
+			names.AttrStatusReason: schema.StringAttribute{
 				Computed:    true,
 				Description: "Additional information about the current status of the Autonomous VM cluster.",
 			},

internal/service/odb/cloud_autonomous_vm_cluster_data_source.go

@@ -87,7 +87,7 @@ func (d *dataSourceCloudAutonomousVmCluster) Schema(ctx context.Context, req dat
 				Computed:    true,
 				Description: "he percentage of total CPU cores currently in use in the Autonomous VM cluster.",
 			},
-			"created_at": schema.StringAttribute{
+			names.AttrCreatedAt: schema.StringAttribute{
 				Computed:    true,
 				CustomType:  timetypes.RFC3339Type{},
 				Description: "The date and time when the Autonomous VM cluster was created.",
@@ -110,15 +110,15 @@ func (d *dataSourceCloudAutonomousVmCluster) Schema(ctx context.Context, req dat
 				ElementType: types.StringType,
 				Description: "The list of database servers associated with the Autonomous VM cluster.",
 			},
-			"description": schema.StringAttribute{
+			names.AttrDescription: schema.StringAttribute{
 				Computed:    true,
 				Description: "The user-provided description of the Autonomous VM cluster.",
 			},
-			"display_name": schema.StringAttribute{
+			names.AttrDisplayName: schema.StringAttribute{
 				Computed:    true,
 				Description: "The display name of the Autonomous VM cluster.",
 			},
-			"domain": schema.StringAttribute{
+			names.AttrDomain: schema.StringAttribute{
 				Computed:    true,
 				Description: "The domain name of the Autonomous VM cluster.",
 			},

internal/service/odb/cloud_autonomous_vm_cluster_data_source_test.go

@@ -54,7 +54,7 @@ func TestAccODBCloudAutonomousVmClusterDataSource_basic(t *testing.T) {
 			{
 				Config: autonomousVMClusterDSTestEntity.avmcBasic(),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttr(dataSourceName, "display_name", *avmc1.DisplayName),
+					resource.TestCheckResourceAttr(dataSourceName, names.AttrDisplayName, *avmc1.DisplayName),
 				),
 			},
 		},

internal/service/odb/cloud_autonomous_vm_cluster_test.go

@@ -131,7 +131,7 @@ func TestAccODBCloudAutonomousVmClusterTagging(t *testing.T) {
 
 				Check: resource.ComposeAggregateTestCheckFunc(
 					autonomousVMClusterResourceTestEntity.checkCloudAutonomousVmClusterExists(ctx, resourceName, &avmc1),
-					resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
+					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "0"),
 				),
 			},
 			{
@@ -143,7 +143,7 @@ func TestAccODBCloudAutonomousVmClusterTagging(t *testing.T) {
 				Config: withTag,
 				Check: resource.ComposeAggregateTestCheckFunc(
 					autonomousVMClusterResourceTestEntity.checkCloudAutonomousVmClusterExists(ctx, resourceName, &avmc2),
-					resource.TestCheckResourceAttr(resourceName, "tags.%", "1"),
+					resource.TestCheckResourceAttr(resourceName, acctest.CtTagsPercent, "1"),
 					resource.TestCheckResourceAttr(resourceName, "tags.env", "dev"),
 					resource.ComposeTestCheckFunc(func(state *terraform.State) error {
 						if strings.Compare(*(avmc1.CloudAutonomousVmClusterId), *(avmc2.CloudAutonomousVmClusterId)) != 0 {