semgrep-fix code suggestion addressed.

Author: ab-cs13

internal/service/odb/cloud_exadata_infrastructure.go

@@ -57,6 +57,7 @@ var ResourceCloudExadataInfrastructure = newResourceCloudExadataInfrastructure
 type resourceCloudExadataInfrastructure struct {
 	framework.ResourceWithModel[cloudExadataInfrastructureResourceModel]
 	framework.WithTimeouts
+	framework.WithImportByID
 }
 
 func (r *resourceCloudExadataInfrastructure) Schema(ctx context.Context, req resource.SchemaRequest, resp *resource.SchemaResponse) {
@@ -482,10 +483,6 @@ func (r *resourceCloudExadataInfrastructure) Delete(ctx context.Context, req res
 	}
 }
 
-func (r *resourceCloudExadataInfrastructure) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
-	resource.ImportStatePassthroughID(ctx, path.Root(names.AttrID), req, resp)
-}
-
 func waitCloudExadataInfrastructureCreated(ctx context.Context, conn *odb.Client, id string, timeout time.Duration) (*odbtypes.CloudExadataInfrastructure, error) {
 	stateConf := &retry.StateChangeConf{
 		Pending:      enum.Slice(odbtypes.ResourceStatusProvisioning),

internal/service/odb/cloud_exadata_infrastructure_data_source_test.go

@@ -36,6 +36,9 @@ func TestAccODBCloudExadataInfrastructureDataSource_basic(t *testing.T) {
 	exaInfraResource := "aws_odb_cloud_exadata_infrastructure.test"
 	exaInfraDataSource := "data.aws_odb_cloud_exadata_infrastructure.test"
 	displayNameSuffix := sdkacctest.RandomWithPrefix(exaInfraDataSourceTestEntity.displayNamePrefix)
+	domain := acctest.RandomDomainName()
+	emailAddress1 := acctest.RandomEmailAddress(domain)
+	emailAddress2 := acctest.RandomEmailAddress(domain)
 
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() {
@@ -46,7 +49,7 @@ func TestAccODBCloudExadataInfrastructureDataSource_basic(t *testing.T) {
 		CheckDestroy:             exaInfraDataSourceTestEntity.testAccCheckCloudExadataInfrastructureDestroy(ctx),
 		Steps: []resource.TestStep{
 			{
-				Config: exaInfraDataSourceTestEntity.basicExaInfraDataSource(displayNameSuffix),
+				Config: exaInfraDataSourceTestEntity.basicExaInfraDataSource(displayNameSuffix, emailAddress1, emailAddress2),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					resource.TestCheckResourceAttrPair(exaInfraResource, names.AttrID, exaInfraDataSource, names.AttrID),
 					resource.TestCheckResourceAttr(exaInfraDataSource, "shape", "Exadata.X9M"),
@@ -82,7 +85,7 @@ func (cloudExaDataInfraDataSourceTest) testAccCheckCloudExadataInfrastructureDes
 	}
 }
 
-func (cloudExaDataInfraDataSourceTest) basicExaInfraDataSource(displayNameSuffix string) string {
+func (cloudExaDataInfraDataSourceTest) basicExaInfraDataSource(displayNameSuffix, emailAddress1, emailAddress2 string) string {
 	testData := fmt.Sprintf(`
 
 
@@ -94,7 +97,7 @@ resource "aws_odb_cloud_exadata_infrastructure" "test" {
   storage_count                    = 3
   compute_count                    = 2
   availability_zone_id             = "use1-az6"
-  customer_contacts_to_send_to_oci = [{ email = "[email protected]" }, { email = "[email protected]" }]
+  customer_contacts_to_send_to_oci = [{ email = %[2]q }, { email = %[3]q }]
   maintenance_window {
     custom_action_timeout_in_mins    = 16
     is_custom_action_timeout_enabled = true
@@ -106,6 +109,6 @@ resource "aws_odb_cloud_exadata_infrastructure" "test" {
 data "aws_odb_cloud_exadata_infrastructure" "test" {
   id = aws_odb_cloud_exadata_infrastructure.test.id
 }
-`, displayNameSuffix)
+`, displayNameSuffix, emailAddress1, emailAddress2)
 	return testData
 }

internal/service/odb/cloud_exadata_infrastructure_test.go

@@ -75,6 +75,9 @@ func TestAccODBCloudExadataInfrastructureResource_withAllParameters(t *testing.T
 	var cloudExaDataInfrastructure odbtypes.CloudExadataInfrastructure
 	resourceName := "aws_odb_cloud_exadata_infrastructure.test"
 	rName := sdkacctest.RandomWithPrefix(exaInfraTestResource.displayNamePrefix)
+	domain := acctest.RandomDomainName()
+	emailAddress1 := acctest.RandomEmailAddress(domain)
+	emailAddress2 := acctest.RandomEmailAddress(domain)
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck: func() {
 			acctest.PreCheck(ctx, t)
@@ -85,7 +88,7 @@ func TestAccODBCloudExadataInfrastructureResource_withAllParameters(t *testing.T
 		CheckDestroy:             exaInfraTestResource.testAccCheckCloudExaDataInfraDestroyed(ctx),
 		Steps: []resource.TestStep{
 			{
-				Config: exaInfraTestResource.exaDataInfraResourceWithAllConfig(rName),
+				Config: exaInfraTestResource.exaDataInfraResourceWithAllConfig(rName, emailAddress1, emailAddress2),
 				Check: resource.ComposeAggregateTestCheckFunc(
 					exaInfraTestResource.testAccCheckCloudExadataInfrastructureExists(ctx, resourceName, &cloudExaDataInfrastructure),
 				),
@@ -337,9 +340,9 @@ func (cloudExaDataInfraResourceTest) testAccCheckCloudExadataInfrastructureExist
 func (cloudExaDataInfraResourceTest) testAccPreCheck(ctx context.Context, t *testing.T) {
 	conn := acctest.Provider.Meta().(*conns.AWSClient).ODBClient(ctx)
 
-	input := &odb.ListCloudExadataInfrastructuresInput{}
+	input := odb.ListCloudExadataInfrastructuresInput{}
 
-	_, err := conn.ListCloudExadataInfrastructures(ctx, input)
+	_, err := conn.ListCloudExadataInfrastructures(ctx, &input)
 
 	if acctest.PreCheckSkipError(err) {
 		t.Skipf("skipping acceptance testing: %s", err)
@@ -349,7 +352,8 @@ func (cloudExaDataInfraResourceTest) testAccPreCheck(ctx context.Context, t *tes
 	}
 }
 
-func (cloudExaDataInfraResourceTest) exaDataInfraResourceWithAllConfig(randomId string) string {
+func (cloudExaDataInfraResourceTest) exaDataInfraResourceWithAllConfig(randomId, emailAddress1, emailAddress2 string) string {
+
 	exaDataInfra := fmt.Sprintf(`
 
 
@@ -359,7 +363,7 @@ resource "aws_odb_cloud_exadata_infrastructure" "test" {
   storage_count                    = 3
   compute_count                    = 2
   availability_zone_id             = "use1-az6"
-  customer_contacts_to_send_to_oci = [{ email = "[email protected]" }, { email = "[email protected]" }]
+  customer_contacts_to_send_to_oci = [{ email =%[2]q }, { email = %[3]q }]
   database_server_type             = "X11M"
   storage_server_type              = "X11M-HC"
   maintenance_window {
@@ -378,7 +382,7 @@ resource "aws_odb_cloud_exadata_infrastructure" "test" {
   }
 
 }
-`, randomId)
+`, randomId, emailAddress1, emailAddress2)
 	return exaDataInfra
 }
 func (cloudExaDataInfraResourceTest) exaDataInfraResourceBasicConfig(displayName string) string {