lint fixes and add libxcb pkg

Author: William Graef

ol/provision_vbox.yml

@@ -12,63 +12,78 @@
 
   tasks:
 
-  - name: Install required packages for virtualbox
-    ansible.builtin.dnf:
-      name:
-        - "kernel-uek-devel-{{ ansible_kernel }}"
-        - gcc
-        - make
-        - perl
-      state: latest
+    - name: Install required packages for virtualbox
+      ansible.builtin.dnf:
+        name:
+          - "kernel-uek-devel-{{ ansible_kernel }}"
+          - gcc
+          - make
+          - perl
+          - libxcb
+        state: present
 
-  - name: Add virtualbox repo keys
-    ansible.builtin.rpm_key:
-      state: present
-      key: https://www.virtualbox.org/download/oracle_vbox_2016.asc
+    - name: Add virtualbox repo keys
+      ansible.builtin.rpm_key:
+        state: present
+        key: https://www.virtualbox.org/download/oracle_vbox_2016.asc
 
-  - name: Add virtualbox repo
-    ansible.builtin.yum_repository:
-      name: virtualbox
-      description: Oracle VirtualBox
-      baseurl: http://download.virtualbox.org/virtualbox/rpm/el/$releasever/$basearch
+    - name: Add virtualbox repo
+      ansible.builtin.yum_repository:
+        name: virtualbox
+        description: Oracle VirtualBox
+        baseurl: http://download.virtualbox.org/virtualbox/rpm/el/$releasever/$basearch
 
-  - name: "Install virtualbox version {{ virtualbox_version }}"
-    ansible.builtin.dnf:
-      name: "VirtualBox-{{ virtualbox_version }}"
-      state: latest
+    - name: "Install virtualbox version {{ virtualbox_version }}"
+      ansible.builtin.dnf:
+        name: "VirtualBox-{{ virtualbox_version }}"
+        state: present
 
-  - name: Check if extension pack is already installed
-    ansible.builtin.shell: "vboxmanage list extpacks"
-    register: extpack_list
+    - name: Check if extension pack is already installed
+      ansible.builtin.shell: |
+        vboxmanage list extpacks
+      register: extpack_list
+      changed_when: extpack_list.rc != 0
 
-  - name: Output installed extpacks
-    ansible.builtin.debug:
-      var: extpack_list.stdout
-      verbosity: 1
+    - name: Output installed extpacks
+      ansible.builtin.debug:
+        var: extpack_list.stdout
+        verbosity: 1
 
-  - name: Download virtualbox extension pack
-    ansible.builtin.get_url:
-      url: 'https://download.virtualbox.org/virtualbox/{{ virtualbox_extpack_version }}/Oracle_VirtualBox_Extension_Pack-{{ virtualbox_extpack_version }}.vbox-extpack'
-      dest: /tmp/
-      force: yes
-    register: download_result
-    when: 'extpack_list.stdout == "Extension Packs: 0"'
+    - name: Download virtualbox extension pack
+      ansible.builtin.get_url:
+        url: "{{ base_url }}/{{ virtualbox_extpack_version }}/Oracle_VirtualBox_Extension_Pack-{{ virtualbox_extpack_version }}.vbox-extpack"
+        dest: /tmp/
+        force: true
+        mode: "0644"
+      register: download_result
+      when: 'extpack_list.stdout == "Extension Packs: 0"'
+      vars:
+        base_url: "https://download.virtualbox.org/virtualbox"
 
-  - name: Output download virtualbox extension pack file name
-    ansible.builtin.debug:
-      var: download_result.dest
-      verbosity: 1
+    - name: Output download virtualbox extension pack file name
+      ansible.builtin.debug:
+        var: download_result.dest
+        verbosity: 1
 
-  - name: Install virtualbox extension pack
-    ansible.builtin.shell: "echo 'y' |  vboxmanage extpack install --replace {{ download_result.dest }}"
-    when: 'extpack_list.stdout == "Extension Packs: 0"'
+    - name: Install virtualbox extension pack
+      ansible.builtin.shell:
+        cmd: |
+          set -o pipefail
+          echo 'y' |  vboxmanage extpack install --replace {{ download_result.dest }}
+        executable: /bin/bash
+      register: install_extpack
+      changed_when: install_extpack != 0
+      when: 'extpack_list.stdout == "Extension Packs: 0"'
 
-  - name: Download the Oracle Linux iso file
-    ansible.builtin.get_url:
-      url: 'https://yum.oracle.com/ISOS/OracleLinux/OL{{ ol_version }}/u{{ ol_update }}/x86_64/OracleLinux-R{{ ol_version }}-U{{ ol_update }}-x86_64-dvd.iso'  
-      dest: /home/{{ username }}
-      force: yes
-    register: download_iso_result
-    until: "'OK' in download_iso_result.msg"
-    retries: 5
-    delay: 10
+    - name: Download the Oracle Linux iso file
+      ansible.builtin.get_url:
+        url: "{{ base_url }}/OL{{ ol_version }}/u{{ ol_update }}/x86_64/OracleLinux-R{{ ol_version }}-U{{ ol_update }}-x86_64-dvd.iso"
+        dest: /home/{{ username }}
+        force: true
+        mode: "0644"
+      register: download_iso_result
+      until: "'OK' in download_iso_result.msg"
+      retries: 5
+      delay: 10
+      vars:
+        base_url: "https://yum.oracle.com/ISOS/OracleLinux"

ol/update_all_rpms.yml

@@ -5,7 +5,7 @@
 # See LICENSE.TXT for details.
 
 - name: Install latest Oracle Linux packages
-  hosts: server
+  hosts: server,vbox
   vars_files:
     - default_vars.yml
   become: true