improve playbook idempotency

Author: bgraef

olvm/configure_secondary_nic.yml

@@ -87,8 +87,8 @@
     - name: Get network interface
       ansible.builtin.set_fact:
         interface: "{{ item }}"
-      with_items: "{{ ansible_interfaces | reject('==', 'lo') }}"
-      when: ansible_facts[item].macaddress == mac_addr
+      with_items: "{{ ansible_interfaces | select('match', '^(ens|enp|eth)') | list }}"
+      when: ansible_facts[item].macaddress is defined and ansible_facts[item].macaddress == mac_addr
 
     - name: Assign static IP
       community.general.nmcli:

olvm/create_instance.yml

@@ -425,7 +425,7 @@
       oracle.oci.oci_compute_instance:
         id: "{{ hostvars[item]['instance_ocid'] }}"
         state: absent
-      loop: "{{ ansible_play_hosts_all | difference(['localhost']) }}"
+      loop: "{{ groups['all'] | difference(['localhost']) }}"
 
     - name: Delete the vlan
       oracle.oci.oci_network_vlan:

olvm/ovirt_add_hosts.yml

@@ -5,7 +5,7 @@
 # See LICENSE.TXT for details.
 
 - name: Add KVM hosts to a Cluster in the Engine server
-  hosts: olvm
+  hosts: engine
   vars_files:
     - default_vars.yml
     - oci_vars.yml