Skip to content

Commit 2ef8725

Browse files
committed
Review Comments incorporated.
1 parent 71e5d4e commit 2ef8725

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

oci-build-examples/oci-build-caching/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ RUN --mount=type=cache,target=/root/.m2 mvn package
1414

1515
FROM openjdk
1616

17-
#maintainer
18-
1917
#expose port 8080
2018
EXPOSE 8080
2119

oci-build-examples/oci-build-caching/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# OCI DevOps - Speed up builds with caching
22

3-
Most of the time the build time is consumed in downloading or preparing certain build dependancies like maven dependencies, node_modules, pip dependancies, etc... This document talks about on how to reduce time by caching those dependencies for the subsequent runs.
3+
In most cases, the build time is consumed in downloading or preparing certain build dependancies like maven dependencies, node_modules, pip dependancies, etc... This procedure talks about on how to reduce time by caching those dependencies for the subsequent runs.
44

55
In this way, the first run would take full time to download and setup build dependancies. But the subsequent runs will be more efficient through the cache.
66

oci-build-examples/oci-build-caching/build_spec.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ env:
77
variables:
88
BUILD_CACHE_OS_BUCKET_NAME: build-cache
99
BUILD_CACHE_OS_FILE_NAME: cache.zip
10+
BUILDX_VERSION: 0.8.2
1011

1112
# exportedVariables are made available to use as parameters in sucessor Build Pipeline stages
1213
# For this Build to run, the Build Pipeline needs to have a BUILDRUN_HASH parameter set
@@ -25,7 +26,7 @@ steps:
2526
name: "Docker BuildKit Setup"
2627
timeoutInSeconds: 140
2728
command: |
28-
wget https://github.com/docker/buildx/releases/download/v0.8.2/buildx-v0.8.2.linux-amd64 -O docker-buildx
29+
wget https://github.com/docker/buildx/releases/download/v${BUILDX_VERSION}/buildx-v${BUILDX_VERSION}.linux-amd64 -O docker-buildx
2930
mkdir -p ~/.docker/cli-plugins
3031
mv docker-buildx ~/.docker/cli-plugins/
3132
chmod +x ~/.docker/cli-plugins/docker-buildx

0 commit comments

Comments
 (0)