Skip to content

Commit d830def

Browse files
committed
PR comments fixes
1 parent f0743da commit d830def

File tree

11 files changed

+15
-10
lines changed

11 files changed

+15
-10
lines changed

oci-build-examples/oci_buildrunner_with_sonarqube/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ EXEC: INFO: ------------- Check Quality Gate status
141141
2022-02-21T12:05:35.387Z
142142
EXEC: INFO: Waiting for the analysis report to be processed (max 300s)
143143
2022-02-21T12:05:40.440Z
144-
EXEC: INFO: QUALITY GATE STATUS: PASSED - View details on http://129.153.5.206:9000/dashboard?id=oci_build_sonar
144+
EXEC: INFO: QUALITY GATE STATUS: PASSED - View details on http://X.Y.Z.A:9000/dashboard?id=oci_build_sonar
145145
2022-02-21T12:05:45.762Z
146146
EXEC: INFO: Analysis total time: 20.561 s
147147
2022-02-21T12:05:45.765Z
@@ -181,7 +181,7 @@ A specific note
181181
182182
----
183183
184-
Its a demo and focused only on `OCI Devops Build services` and `Sonarqube` .The whole pipeline can be reffered here . - https://github.com/RahulMR42/oci-devops-cicd-with-java-graalvm-example.
184+
Its a demo and focused only on `OCI Devops Build services` and `Sonarqube` .The whole pipeline can be referred here . - https://github.com/RahulMR42/oci-devops-cicd-with-java-graalvm-example.
185185
186186
References & Credits for base code
187187
============
@@ -198,7 +198,7 @@ Contributors
198198
===========
199199
200200
- Author : Rahul M R.
201-
- Colloboroators : NA
201+
- Collaborators : NA
202202
- Last release : Feb 2022
203203
204204
### Back to examples.
-43.3 KB
Loading

oci-coderepo-examples/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ All about OCI devops coderepo samples ..
22
=======
33

44
<details>
5-
<summary>To do</summary>
5+
<summary>We will add the details in the next release</summary>
66

77
</details>
88

oci-deployment-examples/oci_helm_function_deployment/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ A sample illustration of helm based installation of OCI OKE,based on artifact up
55

66
ℹ️ Summary of Interactions
77

8-
- Use OCI Service connector hub and invoke a function when there will be repository artifiact upload event occurs.
8+
- Use OCI Service Connector Hub to invoke a function when there is a repository artifact upload event.
99

10-
- The Function will intern deploy the artifiact using helm to the OCI OKE.
10+
- The Function will deploy the artifiact using helm to the OCI OKE.
1111

1212
- The whole interaction is encompassed inside a private Virtual cloud network subnet.
1313

@@ -179,9 +179,9 @@ $ fn deploy -v --app <FN APPLICATION NAME>
179179

180180
- Add an additional query and put data.request.path attribute with * <OCID of REP> *
181181

182-
- Add One more additional filter ,select the Attribute as source and enter * sample-fastapi.zip * .Here we using a wildcard selection with a name ,which will be used as a target path while we will be uploading the helm artifacts to OCI artifacts repo.
182+
- Add One more additional filter ,select the Attribute as source and enter '*sample-fastapi.zip*' .Here we using a wildcard selection with a name ,which will be used as a target path while we will be uploading the helm artifacts to OCI artifacts repo.
183183

184-
![](images/sc_basic
184+
![](images/sc_basic.png)
185185

186186
Or You may switch to Advance mode and paste the below query
187187

@@ -293,7 +293,7 @@ $ git clone https://github.com/RahulMR42/sample-python-app-with-helm-chart
293293
```
294294
$ cd sample-python-app-with-helm-chart
295295
$ docker login <dtr url> (Provide credentials when prompted)
296-
$ docker build -t <dockerurl/sample-python-app:<tag> .
296+
$ docker build -t <dockerurl/sample-python-app:<tag> . (EG: docker build -t <OCI Region>.ocir.io/<Namespace>/sample-python-app:1.0 .)
297297
$ docker push <dockerurl/sample-python-app:<tag>
298298
```
299299
-17.8 KB
Loading
-6.36 KB
Loading
-366 Bytes
Loading

oci-pipeline-examples/oci-java-graalvm-devops-example/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ Sample illustration of build and deploy a polyglot application with Graal VM and
22

33
-------
44

5+
Target Audiences : Intermediate/Advanced towards OCI
6+
57
🪄 Objective .
68

79
- Make a sample build and deploy using Polyglot application with Graal VM.

oci-pipeline-examples/oci-java-micronaut-devops-example/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ Sample illustration of JAVA application with [Micronaut](https://micronaut.io/)
22

33
------------
44

5+
Target Audience : Intermediate/Advanced towards OCI
56

67
Objective
78
---
@@ -39,6 +40,8 @@ Procedure
3940

4041
- We need a code repo to build the managed build stage inside an OCI build pipeline.
4142

43+
- You may change the `gradle version` to latest by updating the values in the file [gradle.properties.](gradle.properties)
44+
4245
- Add a managed build statge to the build pipeline. -
4346

4447
https://docs.oracle.com/en-us/iaas/Content/devops/using/add_buildstage.htm#add_buildstage
@@ -83,7 +86,7 @@ https://docs.oracle.com/en-us/iaas/Content/devops/using/add_buildstage.htm#add_b
8386
![](images/buildpview.png)
8487

8588

86-
- Do a test Run.
89+
- Do a test Run via `Build pipeline` >`Manual Run`.
8790

8891
![](images/buildtest.png)
8992

-22.9 KB
Loading

0 commit comments

Comments
 (0)