Connection and credential variables validated for empty strings

In variables for DB system connections, it´s validated whether usernames, passwords, hosts, service names, and agent IDs are provided in JSON-input as empty strings. This is to stop apply early before anything is actually created in OCI

Port and protocol variable definitions have not been changed since the former has a default value and the latter has alternative validation

Author: mitoeth

manageability-and-operations/observability-and-manageability/external-database-enablement/root_module/modules/container/container_connection/variables.tf

@@ -7,6 +7,10 @@ variable "compartment_ocid" {
 variable "external_database_connector_connection_string_hostname" {
   description = "Hostname for connection string"
   type        = string
+  validation {
+  	condition = var.external_database_connector_connection_string_hostname != ""
+	error_message = "The value of 'host' in the JSON-input for database systems is an empty string"
+  }
 }
 
 variable "external_database_connector_connection_string_port" {
@@ -33,6 +37,10 @@ variable "ssl_secret_id" {
 variable "external_database_connector_agent_id" {
   description = "The OCID for the management agent used for database connections"
   type        = string
+  validation {
+  	condition = var.external_database_connector_agent_id != ""
+	error_message = "The value of 'managementAgentId' in the JSON-input for database systems is an empty string"
+  }
   #default = "ocid1.managementagent.oc1..XXXXXXX"
 }
 
@@ -64,6 +72,10 @@ variable "external_cdb_connector_connection_credentials_credential_type" {
 variable "external_cdb_connector_connection_credentials_password" {
   description = "Password for container database connector"
   type        = string
+  validation {
+	condition = var.external_cdb_connector_connection_credentials_password != ""
+	error_message = "Container database connector password is an empty string. Confirm values in the JSON-input for credentials"
+  }
 }
 
 variable "external_cdb_connector_connection_credentials_role" {
@@ -78,9 +90,17 @@ variable "external_cdb_connector_connection_credentials_role" {
 variable "external_cdb_connector_connection_credentials_username" {
   description = "Username for container database connector"
   type        = string
+  validation {
+	condition = var.external_cdb_connector_connection_credentials_username != ""
+	error_message = "Container database connector username is an empty string. Confirm values in the JSON-input for credentials"
+  }
 }
 
 variable "external_cdb_connector_connection_string_service" {
   description = "Service name for container database connector"
   type        = string
+  validation {
+    condition = var.external_cdb_connector_connection_string_service != ""
+	error_message = "The value of 'containerServiceName' in the JSON-input for database systems is an empty string"
+  }
 }

manageability-and-operations/observability-and-manageability/external-database-enablement/root_module/modules/pdb/variables.tf

@@ -69,6 +69,10 @@ variable "external_pdb_connector_connection_credentials_credential_type" {
 variable "external_pdb_connector_connection_credentials_password" {
   description = "Password for pluggable database connector"
   type        = string
+  validation {
+	condition = var.external_pdb_connector_connection_credentials_password != ""
+	error_message = "Pluggable database connector password is an empty string. Confirm values in the JSON-input for credentials"
+  }
 }
 
 variable "external_pdb_connector_connection_credentials_role" {
@@ -83,11 +87,19 @@ variable "external_pdb_connector_connection_credentials_role" {
 variable "external_pdb_connector_connection_credentials_username" {
   description = "Username for pluggable database connector"
   type        = string
+  validation {
+	condition = var.external_pdb_connector_connection_credentials_username != ""
+	error_message = "Pluggable database connector username is an empty string. Confirm values in the JSON-input for credentials"
+  }
 }
 
 variable "external_pdb_connector_connection_string_service" {
   description = "Service name for pluggable database connector"
   type        = string
+  validation {
+    condition = var.external_pdb_connector_connection_string_service != ""
+	error_message = "The value of 'pdbServiceName' in the JSON-input for database systems is an empty string"
+  }
 }
 
 variable "enable_database_management_pdb" {