Skip to content

Commit 5464f56

Browse files
small fixes - code cleanup
1 parent cdd1272 commit 5464f56

File tree

1 file changed

+11
-19
lines changed
  • data-platform/autonomous-database/autonomous-json/SODAJavaDemo/src/main/java/com/oracle

1 file changed

+11
-19
lines changed

data-platform/autonomous-database/autonomous-json/SODAJavaDemo/src/main/java/com/oracle/Main.java

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,22 @@
1-
21
package com.oracle;
32

4-
import java.sql.Connection;
5-
63
import oracle.soda.*;
74
import oracle.soda.rdbms.OracleRDBMSClient;
85
import oracle.jdbc.datasource.impl.OracleDataSource;
9-
/*import oracle.soda.OracleCursor;
10-
import oracle.soda.OracleCollection;
11-
import oracle.soda.OracleDocument;
12-
*/
13-
14-
import java.sql.DriverManager;
156
import java.util.List;
16-
import java.util.Properties;
177

188
public class Main {
19-
//private static OracleDatabase sodaDb;
20-
219
private static OracleDatabase sodaDb;
2210
private static OracleDatabaseAdmin sodaDbAdmin;
2311
private static OracleCollection sodaSampleCollection;
2412

25-
2613
public static void prepareSODAConnection() throws Exception {
27-
Properties props = new Properties();
28-
props.setProperty("user",System.getenv("DB_USERNAME"));
29-
props.setProperty("password",System.getenv("DB_PASSWORD"));
30-
Connection con = DriverManager.getConnection(System.getenv("DB_URL"),props);
14+
OracleDataSource ods = new OracleDataSource();
15+
ods.setURL(System.getenv("DB_URL"));
16+
ods.setUser(System.getenv("DB_USERNAME"));
17+
ods.setPassword(System.getenv("DB_PASSWORD"));
3118
OracleRDBMSClient client = new OracleRDBMSClient();
32-
sodaDb = client.getDatabase(con);
19+
sodaDb = client.getDatabase(ods.getConnection());
3320
sodaDbAdmin = sodaDb.admin();
3421
}
3522

@@ -73,7 +60,6 @@ public static void insertSampleData() throws Exception {
7360
}
7461

7562
public static void findSampleData() throws Exception {
76-
7763
System.out.println("Looking for document 12");
7864
OracleCursor cursor = sodaSampleCollection.find().filter("{\"value\":12}").getCursor();
7965
System.out.println("Results : ");
@@ -85,13 +71,19 @@ public static void findSampleData() throws Exception {
8571
}
8672
}
8773

74+
public static void closeSODAConnection() throws Exception {
75+
sodaDbAdmin.getConnection().close();
76+
System.out.println("Database connection closed succesfully.");
77+
}
78+
8879
public static void main(String[] args) {
8980
try {
9081
prepareSODAConnection();
9182
listExistingCollections();
9283
resetSampleCollection();
9384
insertSampleData();
9485
findSampleData();
86+
closeSODAConnection();
9587
}
9688
catch (Exception e) {e.printStackTrace();}
9789
}

0 commit comments

Comments
 (0)