Use locals in terraform

Author: fzarrioracle

security/security-design/fn-datasafe-dbaudit-to-oci-logging/terraform/buckets.tf

@@ -14,7 +14,7 @@ data "oci_objectstorage_namespace" "bucket_namespace" {
 
 resource "oci_objectstorage_bucket" "tracker-bucket" {
   compartment_id        = var.compartment_ocid
-  name                  = "${var.tracker-bucket}-${var.deployment_name}-${random_id.tag.hex}"
+  name                  = local.tracker_bucket_name
   namespace             = data.oci_objectstorage_namespace.bucket_namespace.namespace
 
 }

security/security-design/fn-datasafe-dbaudit-to-oci-logging/terraform/container_repository.tf

@@ -14,5 +14,5 @@
 resource "oci_artifacts_container_repository" "fn_container_repository" {
 
   compartment_id = var.compartment_ocid
-  display_name   = "${var.ocir_repo_name}-${var.deployment_name}-${random_id.tag.hex}"
+  display_name   = local.oci_repo_displayname
 }

security/security-design/fn-datasafe-dbaudit-to-oci-logging/terraform/functions.tf

@@ -11,28 +11,28 @@
 
 resource "oci_functions_application" "DataSafeAuditDBtoLoggingApp" {
   compartment_id = var.compartment_ocid
-  display_name   = "${var.FunctionAppNamePrefix}-${var.deployment_name}-${random_id.tag.hex}"
+  display_name   = local.functionapp_display_name
   subnet_ids     = [var.create_network ? module.setup-network[0].subnet_ocid : var.subnet_ocid] 
 }
 
 resource "oci_functions_function" "postauditlogs" {
   depends_on     = [null_resource.DataSafeAuditDBtoLoggingPush2OCIR]
   application_id = oci_functions_application.DataSafeAuditDBtoLoggingApp.id
-  display_name   = "${var.FunctionNamePrefix}-${var.deployment_name}"
+  display_name   = local.function_display_name
   #image          = "${local.ocir_docker_repository}/${local.namespace}/${var.ocir_repo_name}/${var.FunctionNamePrefix}:0.0.1"
-  image          = "${local.ocir_docker_repository}/${local.namespace}/${oci_artifacts_container_repository.fn_container_repository.display_name}/${var.FunctionNamePrefix}:0.0.1"
+  image          = "${local.ocir_docker_repository}/${local.namespace}/${oci_artifacts_container_repository.fn_container_repository.display_name}/${local.function_display_name}:0.0.1"
   memory_in_mbs  =  var.FunctionMemory
   timeout_in_seconds = var.FunctionTimeoutSec
   config = {
-    "ociDataSafeCompartmentOCID" : "${var.tenancy_ocid}"
-    "ociOSTrackerBucketName" : "${oci_objectstorage_bucket.tracker-bucket.name}",
-    "ociLoggingLogOCID" : "${oci_logging_log.log_datadafe_auditdb.id}"
+    "ociDataSafeCompartmentOCID" : var.tenancy_ocid
+    "ociOSTrackerBucketName" : local.tracker_bucket_name
+    "ociLoggingLogOCID" : oci_logging_log.log_datadafe_auditdb.id
   }
 
 }
 
 resource "oci_logging_log" "log_on_fn_invoke" {
-  display_name = "${var.FunctionInvokeOCILoggingName}-${var.deployment_name}-${random_id.tag.hex}"
+  display_name = local.function_invoke_oci_logging_displayname
   log_group_id = oci_logging_log_group.log_group.id
   log_type     = "SERVICE"
 

security/security-design/fn-datasafe-dbaudit-to-oci-logging/terraform/locals.tf

@@ -16,4 +16,9 @@ locals {
   resource_nc = "-${var.deployment_name}-${var.region}-${var.purpose}-${random_id.tag.hex}"
   policy_displayname = "${var.PolicyNamePrefix}${local.resource_nc}"
   dynamicgroup_displayname = "${var.DynamicGroupNamePrefix}${local.resource_nc}"
+  tracker_bucket_name = "${var.tracker-bucket}${local.resource_nc}"
+  oci_repo_displayname = "${var.ocir_repo_name}${local.resource_nc}"
+  functionapp_display_name = "${var.FunctionAppNamePrefix}${local.resource_nc}"
+  function_display_name = "${var.FunctionNamePrefix}${local.resource_nc}"
+  function_invoke_oci_logging_displayname = "${var.FunctionInvokeOCILoggingName}${local.resource_nc}"
 }