-
Notifications
You must be signed in to change notification settings - Fork 83
Ios iam py sdk #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ios iam py sdk #1296
Conversation
oheimburger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the scrren shot with the tokens includes PII data, you should drop this branch and create a new one with a sanitized screen shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mask the tokens. They can contain PII data!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are fake, no real data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it easier to recognize as a redacted token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include a verbatim copy of the OBE. Link to the OBE is good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a new commit to the branch with the file removed and reference in README removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, There is a few issues. I create a new branch with the changes and submit it
Removed reference to OBE pdf.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
I'm working on adding an OCA agreement for the email I (accidentally) committed under, so this check will be passed as soon as that's approved. I can force a merge in the meantime if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it easier to recognize as a redacted token.
I have added a reusable assets for OCI IAM DSK Python SDK authentication. It is based on old Oracle By Example and the SDK download from the OCI IAM Domain console. But both these are outdated, old PY versions and old depreciated features of PY packages. The assets reflects update to Py 3.0 and the latest PY packages. With this asset we have a running example of how to use OAUTH and OCI IAM PY SDK for application authentication. If the customer stick to the most recent SDK example in the console and the OBE, it will fail.