External dbs observability and management v2 #856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
oheimburger
requested changes
Mar 15, 2024
...external-database-enablement/root_module/modules/container/container_connection/variables.tf
Show resolved
Hide resolved
...vability-and-manageability/external-database-enablement/root_module/modules/pdb/variables.tf
Show resolved
Hide resolved
...bility-and-operations/observability-and-manageability/external-database-enablement/README.md
Show resolved
Hide resolved
At line 53, it´s noted that the Terraform config will set port to 1521 if no value is provided in JSON-input At line 84-85, it´s noted that credential details are visible as plain text in both the JSON-input and in the tfstate, so both files should be managed securely
In variables for DB system connections, it´s validated whether usernames, passwords, hosts, service names, and agent IDs are provided in JSON-input as empty strings. This is to stop apply early before anything is actually created in OCI Port and protocol variable definitions have not been changed since the former has a default value and the latter has alternative validation
oheimburger
previously requested changes
May 6, 2024
...external-database-enablement/root_module/modules/container/container_connection/variables.tf
Outdated
Show resolved
Hide resolved
...vability-and-manageability/external-database-enablement/root_module/modules/pdb/variables.tf
Outdated
Show resolved
Hide resolved
...ations/observability-and-manageability/external-database-enablement/root_module/variables.tf
Outdated
Show resolved
Hide resolved
Default OCID variable value placeholders removed from variable files in the root, container_connection, and pdb module
added copyright
"Copyright (c) 2025 Oracle and/or its affiliates." Has been added add the beginning of every TF-file
AlexanderHodicke
approved these changes
Mar 25, 2025
AlexanderHodicke
dismissed
oheimburger’s stale review
As per call - Just Copyright updates - Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: New pull request after adding password placeholders in db_credentials.json and db_credentials_example.json
I made a Terraform configuration to enable the following services in Observability & Management for external databases with agents.
The configuration will do the setup based on input from two JSON-files: db_systems.json and db_credentials.json