Skip to content

Commit 828cbb9

Browse files
Policy updates required for RDMA clusters and deploying to different compartments added to admin deployment and docs. (#65)
1 parent 668aa10 commit 828cbb9

File tree

4 files changed

+15
-1
lines changed

4 files changed

+15
-1
lines changed

docs/api_documentation.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
| Parameter | Type | Required | Description |
1010
| -------------------------------------------- | ------- | -------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
1111
| recipe_id | string | Yes | One of the following: `llm_inference_nvidia`, `lora_finetune_nvidia`, or `mlcommons_lora_finetune_nvidia` |
12+
| recipe_compartment_ocid | string | No | The OCID of the compartment where the blueprint should be deployed. Note, this will require additional policy scope for blueprints to use resources such as object storage in this compartment. |
1213
| deployment_name | string | Yes | Any deployment name to identify the deployment details easily. Must be unique from other recipe deployments. |
1314
| recipe_mode | string | Yes | One of the following: `service`, `job`, `update`, or `shared_node_pool`. Enter `service` for inference recipe deployments, `job` for fine-tuning recipe deployments, `update` for updating existing deployments (currently only supported for MIG), and `shared_node_pool` for creating a shared node pool. |
1415
| recipe_node_labels | object[string][string] | No | Additional labels to apply to a node pool in the form `{"label": "value"}` |

docs/custom_blueprints/blueprint_json_schema.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@
3535
"recipe_id": {
3636
"type": "string"
3737
},
38+
"recipe_compartment_ocid": {
39+
"type": "string"
40+
},
3841
"deployment_name": {
3942
"type": "string"
4043
},

docs/iam_policies.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ More info on dynamic groups can be found here: https://docs.oracle.com/en-us/iaa
3434
```
3535
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to inspect all-resources in tenancy
3636
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to manage all-resources in compartment {comparment_name}
37+
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to {CLUSTER_JOIN} in compartment {compartment_name}
38+
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to manage volumes in TENANCY where request.principal.type = 'cluster'
39+
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to manage volume-attachments in TENANCY where request.principal.type = 'cluster'
3740
```
3841

3942
**Option #2: Fine-Grain Access:**
@@ -98,4 +101,8 @@ Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to inspect compartme
98101
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to manage cluster-node-pools in compartment {compartment_name}
99102
100103
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to {CLUSTER_JOIN} in compartment {compartment_name}
104+
105+
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to manage volumes in TENANCY where request.principal.type = 'cluster'
106+
107+
Allow dynamic-group 'IdentityDomainName'/'DynamicGroupName' to manage volume-attachments in TENANCY where request.principal.type = 'cluster'
101108
```

oci_ai_blueprints_terraform/policies.tf

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,11 @@ resource "oci_identity_policy" "oke_instances_tenancy_policy" {
2424
statements = [
2525
"Allow dynamic-group 'Default'/'${oci_identity_dynamic_group.dyn_group[0].name}' to manage all-resources in compartment ${data.oci_identity_compartment.oci_compartment.name}",
2626
"Allow dynamic-group 'Default'/'${oci_identity_dynamic_group.dyn_group[0].name}' to use all-resources in tenancy",
27+
"Allow dynamic-group 'Default'/'${oci_identity_dynamic_group.dyn_group[0].name}' to {CLUSTER_JOIN} in compartment ${data.oci_identity_compartment.oci_compartment.name}",
28+
"Allow dynamic-group 'Default'/'${oci_identity_dynamic_group.dyn_group[0].name}' to manage volumes in TENANCY where request.principal.type = 'cluster'",
29+
"Allow dynamic-group 'Default'/'${oci_identity_dynamic_group.dyn_group[0].name}' to manage volume-attachments in TENANCY where request.principal.type = 'cluster'"
2730
]
2831
freeform_tags = local.corrino_tags
2932
count = var.policy_creation_enabled ? 1 : 0
3033
depends_on = [oci_identity_dynamic_group.dyn_group]
31-
}
34+
}

0 commit comments

Comments
 (0)