Skip to content

Commit 076df17

Browse files
authored
Update values.yaml (#53)
Fixes false positive on L40s with WPA errors. Return for check when BM shapes that are not explicitly listed should be the same for VMs and return an empty list. Previously it return a string stating that the shape was unsupported. That string was being resulted in the false positive. Conditional now returns an empty list, VMs specific conditional was removed as it is now redundent.
1 parent 2e73506 commit 076df17

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

manifests/node-problem-detector/values.yaml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,11 +1078,6 @@ settings:
10781078
def check_wpa_auth(metadata):
10791079
shape = metadata.get('shape')
10801080
1081-
# Skip the test for VM shapes
1082-
if shape.startswith("VM."):
1083-
pass
1084-
return []
1085-
10861081
if shape in ["BM.GPU.H100.8", "BM.GPU.B4.8", "BM.GPU.A100-v2.8", "BM.GPU4.8"]:
10871082
interface_range = range(16)
10881083
required_authenticated = 16
@@ -1091,7 +1086,7 @@ settings:
10911086
required_authenticated = 8
10921087
else:
10931088
logger.error("Unsupported machine shape.")
1094-
return ["Unsupported machine shape."]
1089+
return []
10951090
10961091
authenticated_count = 0
10971092
wpa_auth_issues = []
@@ -2231,4 +2226,4 @@ extraContainers: []
22312226
# updateStrategy -- Manage the daemonset update strategy
22322227
updateStrategy: RollingUpdate
22332228
# maxUnavailable -- The max pods unavailable during an update
2234-
maxUnavailable: 1
2229+
maxUnavailable: 1

0 commit comments

Comments
 (0)