Fix link flapping if the flapping happened close to boot

Author: arnaudfroidmont

playbooks/roles/healthchecks/files/rdma_link_flapping.py

@@ -102,7 +102,7 @@ def process_rdma_link_flapping(self):
                     logger.debug(f"RDMA link ({interface}) failed  {diff_hours} hours ago")
 
                     logger.debug(f"bootup_time_sec: {bootup_time_sec}, boot_time_grace_period: {bootup_time_grace_period}, current_date_sec: {current_date_sec}, diff_secs: {diff_secs}, diff_hours: {diff_hours}")
-                    if diff_hours < self.time_interval and current_date_sec > bootup_time_grace_period:
+                    if diff_hours < self.time_interval and last_date_failure_sec > bootup_time_grace_period:
                         logger.debug(f"{interface}: one or more RDMA link flapping events within {self.time_interval} hours. Last flapping event: {last_date_failure_str})")
                         link_issues["failures"].append(f"{interface}: {len(self.link_data[interface]['failures'])}")
                         status = -1
@@ -135,7 +135,7 @@ def process_rdma_link_flapping(self):
                     logger.debug(f"RDMA link ({interface}) down  {diff_hours} hours ago")
 
                     logger.debug(f"bootup_time_sec: {bootup_time_sec}, boot_time_grace_period: {bootup_time_grace_period}, current_date_sec: {current_date_sec}, diff_secs: {diff_secs}, diff_hours: {diff_hours}")
-                    if diff_hours < self.time_interval and current_date_sec > bootup_time_grace_period:
+                    if diff_hours < self.time_interval and last_date_down_sec > bootup_time_grace_period:
                         logger.debug(f"{interface}, one or more RDMA link down events within {self.time_interval} hours. Last link down event: {last_date_down_str}")
                         link_issues["link_down"].append(f"{interface}: {len(self.link_data[interface]['link_down'])}")
                         status = -2